#5186 - Add ambiguous monomers to the library and allow their addition to the canvas #5358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrodionov91
force-pushed
the
5186-add-variant-monomers-to-library
branch
from
3c32948
to
afe6429
Compare
svvald
approved these changes
Aug 27, 2024
| position, | ||
| ); | ||
| if (isAmbiguousMonomerLibraryItem(this.monomer)) { | ||
| modelChanges = this.editor.drawingEntitiesManager.addVariantMonomer( |
There was a problem hiding this comment.
I suppose this method of drawingEntitiesManager has to be renamed as well
There was a problem hiding this comment.
Will do in next PR
There was a problem hiding this comment.
There was some left gap previously for presets, now it is present for 'No natural analogue' group, probably it might be fixed as well?
| @@ -47,12 +50,13 @@ const MonomerItem = ({ | |||
| disabled={isDisabled} | |||
| data-testid={monomerKey} | |||
| data-monomer-item-id={monomerKey} | |||
| isVariantMonomer={item.isAmbiguous} | |||
There was a problem hiding this comment.
This prop has to be renamed too
There was a problem hiding this comment.
Will do in next PR
…n to the canvas - added ambiguous monomers to the library
- updated snapshots
- fixed chems library
rrodionov91
force-pushed
the
5186-add-variant-monomers-to-library
branch
from
97d66cc
to
b1f88e3
Compare
Guch1g0v
pushed a commit
that referenced
this pull request
Oct 17, 2024
…n to the canvas (#5358) - added ambiguous monomers to the library - updated screenshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
Check list
#1234 – issue name