Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo operation removes ambiguous monomer from the canvas but keep in the KET file export #5464

Closed
AlexeyGirin opened this issue Sep 10, 2024 · 1 comment · Fixed by #5461 or #5485
Closed

Undo operation removes ambiguous monomer from the canvas but keep in the KET file export #5464

AlexeyGirin opened this issue Sep 10, 2024 · 1 comment · Fixed by #5461 or #5485
Assignees
@rrodionov91
Labels
bug Flex mode Bucket: Flex canvas related mode Priority: High
Milestone
Ketcher 2.25.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Sep 10, 2024 •
edited
Loading

Steps to Reproduce

  1. Toggle to Macro - Flex
  2. Put ambiguous monomer from the library to the canvas (it was X peptide in my case)
    image
  3. Press Undo button (monomer disappears from the canvas - This is ok)
  4. Press Save button

Actual behavior
Removed monomer remain in the KET export result
image

Expected behavior
Export result is almost empty
image

Versions

  • Ketcher Version 2.25.0-rc.1 Build at 2024-09-03; 15:31:03
  • Indigo Toolkit Version 1.24.0-rc.1.0-gb8f099851-wasm32-wasm-clang-19.0.0
  • Chrome Version 128.0.6613.114 (Official Build) (64-bit)
  • Win10

Reference issues: #4554
@AlexeyGirin AlexeyGirin added bug Priority: High Flex mode Bucket: Flex canvas related mode labels Sep 10, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.25.0-rc.2 milestone Sep 10, 2024
@rrodionov91 rrodionov91 self-assigned this Sep 10, 2024
This was linked to pull requests Sep 10, 2024
#5425 - Undo-Redo operations over ambiguous monomer causes broken canvas #5461
Merged
Backmerge: #5425 - Undo-Redo operations over ambiguous monomer causes broken canvas #5485
Merged
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image
Versions

  • Ketcher Version 2.25.0-rc.2 Build at 2024-09-14; 10:47:47
  • Indigo Toolkit Version 1.24.0-rc.2.0-g5f2751d70-wasm32-wasm-clang-19.0.0
  • Chrome Version 128.0.6613.138 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Flex mode Bucket: Flex canvas related mode Priority: High
Projects
None yet
Milestone
Ketcher 2.25.0-rc.2
2 participants
@rrodionov91 @AlexeyGirin