Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo-Redo operations over ambiguous monomer causes broken canvas #5425

Closed
AlexeyGirin opened this issue Sep 4, 2024 · 1 comment · Fixed by #5461 or #5485
Closed

Undo-Redo operations over ambiguous monomer causes broken canvas #5425

AlexeyGirin opened this issue Sep 4, 2024 · 1 comment · Fixed by #5461 or #5485
Assignees
@rrodionov91
Labels
bug Priority: High Sequence mode Bucket: Sequence mode related issues
Milestone
Ketcher 2.25.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Toggle to Macro - Sequence mode
  2. Load from file: Undo-Redo operations over ambiguous monomer causes broken canvas.zip
    image
  3. Select monomer
    image
  4. Copy it to clipboard (press Copy+C)
  5. Press Copy+V
    image
  6. Press Undo button

Actual behavior
Nothing happens
image
More over - games with Undo-redo can cause unremovable elements on the canvas

Expected behavior
Pasted monomer disappears
image

Versions

  • Ketcher Version 2.25.0-rc.1 Build at 2024-09-03; 15:31:03
  • Indigo Toolkit Version 1.24.0-rc.1.0-gb8f099851-wasm32-wasm-clang-19.0.0
  • Chrome Version 128.0.6613.114 (Official Build) (64-bit)
  • Win10

Reference issues: #4556
@AlexeyGirin AlexeyGirin added bug Priority: High Sequence mode Bucket: Sequence mode related issues labels Sep 4, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.25.0-rc.2 milestone Sep 4, 2024
@rrodionov91 rrodionov91 self-assigned this Sep 9, 2024
This was linked to pull requests Sep 10, 2024
#5425 - Undo-Redo operations over ambiguous monomer causes broken canvas #5461
Merged
Backmerge: #5425 - Undo-Redo operations over ambiguous monomer causes broken canvas #5485
Merged
@Zhirnoff
Copy link
Collaborator

Tested. Bug fixed.

2024-09-16_16h05_05.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.25.0-rc.2]
Indigo version
[Version 1.24.0-rc.2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Priority: High Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Ketcher 2.25.0-rc.2
3 participants
@rrodionov91 @AlexeyGirin @Zhirnoff