Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When several reactions on canvas are positioned one under another, reaction(s) can't be saved correctly to RXN or RDF #2454

Closed
ivanmaslow opened this issue Sep 30, 2024 · 2 comments · Fixed by #2570
Assignees
Labels
Bug Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: High

Comments

@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Sep 30, 2024

Steps to Reproduce

  1. Add to Canvas reaction from KET:
    ket-issue-2.zip
    image
  2. Click on Save to RXN (RDF)

Actual Result

  • All reactants from different reactions are united together and all products are united together:
    image

Expected Result

  • Only one reaction should be saved to RXN (the set of separate reactions should be saved to RDF)

Environment details

  • Detected on CI-CD environment with 2309-update-layout build
  • Ketcher [Version 2.25.0-rc.2] Build at 2024-09-30; 06:32:00
  • Version 1.25.0-dev.2.6-g0e1cfa10-wasm32-wasm-clang-12.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 129.0.6668.71 (Official Build) (64-bit)

Notes

@ivanmaslow ivanmaslow added Bug Priority: High Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes labels Sep 30, 2024
@ivanmaslow ivanmaslow added this to the Indigo-1.25.0-rc.1 milestone Sep 30, 2024
@ivanmaslow ivanmaslow changed the title Preview: When several reactions on canvas are positioned one under another, reaction(s) can't be saved correctly to RXN(RDF) When several reactions on canvas are positioned one under another, reaction(s) can't be saved correctly to RXN(RDF) Oct 4, 2024
@ivanmaslow ivanmaslow changed the title When several reactions on canvas are positioned one under another, reaction(s) can't be saved correctly to RXN(RDF) When several reactions on canvas are positioned one under another, reaction(s) can't be saved correctly to RXN or RDF Oct 7, 2024
@ivanmaslow
Copy link
Collaborator Author

Pre-tested on aws_ci environment with Ketcher master and Indigo 2407-branch-ordering branches:

  • Ketcher [Version 2.26.0-rc.1] Build at 2024-10-24; 12:25:38;
  • Indigo Version 1.25.0-rc.3.18-gcdee98d4-wasm32-wasm-clang-12.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 130.0.6723.70 (Official Build) (64-bit)

It can be saved correctly to RXN, but not the first reaction is saved to RXN separate defect - #2482 and there is a problem with the arrow after loading:
image

It can be correctly saved to RDF and loaded:
image

But there is an issue with ordering if we make a Undo/Redo for adding of reactions, after that if user makes Layout or save/load to/from RDF, ordering will be changed:
image

@ivanmaslow
Copy link
Collaborator Author

The fix is tested on RC SA env:

  • Ketcher [Version 2.26.0-rc.6] Build at 2024-10-25; 09:57:12;
  • Indigo Version 1.25.0-rc.4.0-g8862ccb7e-wasm32-wasm-clang-19.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome, Version 130.0.6723.70 (Official Build) (64-bit)

As mentioned above the case from the defect is fixed and reaction can be saved correctly to RXN/RDF:
image
image

As for issue with not correct arrow after loading from RXN, it will be fixed in scope of these tasks:

As for problem that not the first reaction on Canvas is saved to RXN - will be fixed in scope of #2482

As for problem with Undo/Redo, new defect is reported - #2585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: High
Projects
None yet
3 participants