Shift timecode floats forward a few picoseconds#63
Merged
eoyilmaz merged 7 commits intoeoyilmaz:developfrom Dec 31, 2025
Merged
Shift timecode floats forward a few picoseconds#63eoyilmaz merged 7 commits intoeoyilmaz:developfrom
eoyilmaz merged 7 commits intoeoyilmaz:developfrom
Conversation
|
May you want to not hardcode a value, you may consider math.nextafter(x, y) introduced in Python 3.9, at the cost of dropping 3.7 and 3.8 support. |
Author
|
Oh that's great! Implemented that conditional for >=3.9. It looks like the typical offset is between 1e-15 and 5e-13, so less than half a picosecond most of the time. |
Test that the resulting floats truncate down to the correct frame number when used to construct a timecode Closes eoyilmaz#61
To tolerate epsilon added to timecode float representation
nickswalker
force-pushed
the
float-eps
branch
from
abe405f to
a4757b5
Compare
nickswalker
force-pushed
the
float-eps
branch
from
d972296 to
3ac9e09
Compare
eoyilmaz
added a commit
that referenced
this pull request
Jan 27, 2026
eoyilmaz
added a commit
that referenced
this pull request
Jan 27, 2026
eoyilmaz
added a commit
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test that the resulting floats truncate down to the correct frame number when used to construct a timecode
Closes #61