Skip to content

Commit 6fe8a6b

Browse files
author
Philipp Marien
committed
Merge branch 'release/3.1.0'
2 parents ac365ce + 79d7f01 commit 6fe8a6b

File tree

4 files changed

+35
-32
lines changed

4 files changed

+35
-32
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
## Change Log
22

3+
### 3.1.0
4+
* changed "set included" to "merge included"
5+
36
### 3.0.0
47
* removed pagination and moved it to json api common
58
* removed special requests and moved it to json api common

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"minimum-stability": "stable",
2323
"require": {
2424
"php": ">=7.2",
25-
"enm/json-api-common": "^3.0"
25+
"enm/json-api-common": "^3.2"
2626
},
2727
"require-dev": {
2828
"phpunit/phpunit": "^7.0"

composer.lock

Lines changed: 28 additions & 28 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/JsonApiServer.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,11 +191,11 @@ protected function includeRelated(
191191
$shouldIncludeRelationship = $request->requestsInclude($relationship->name());
192192
$subRequest = $request->createSubRequest($relationship->name(), $resource);
193193
foreach ($relationship->related()->all() as $related) {
194-
if ($shouldIncludeRelationship && !$document->included()->has($related->type(), $related->id())) {
195-
$document->included()->set($related);
194+
if ($shouldIncludeRelationship) {
195+
$document->included()->merge($related);
196196
}
197197
$this->includeRelated($document, $related, $subRequest);
198-
$this->cleanUpResource($related, $subRequest);
198+
$this->cleanUpResource($document->included()->get($related->type(), $related->id()), $subRequest);
199199
}
200200
}
201201
}

0 commit comments

Comments
 (0)