Remove the condition argument from warning() (#17568)

* prep for codemod

* prep warnings

* rename lint rules

* codemod for ifs

* shim www functions

* Handle more cases in the transform

* Thanks De Morgan

* Run the codemod

* Delete the transform

* Fix up confusing conditions manually

* Fix up www shims to match expected API

* Also check for low-pri warning in the lint rule

Author: walaura

src/ReactShallowRenderer.js

@@ -63,7 +63,6 @@ function areHookInputsEqual(
   if (prevDeps === null) {
     if (__DEV__) {
       warning(
-        false,
         '%s received a final argument during this render, but not during ' +
           'the previous render. Even though the final argument is optional, ' +
           'its type cannot change between renders.',
@@ -78,7 +77,6 @@ function areHookInputsEqual(
     // passed inline.
     if (nextDeps.length !== prevDeps.length) {
       warning(
-        false,
         'The final argument passed to %s changed size between renders. The ' +
           'order and size of this array must remain constant.\n\n' +
           'Previous: %s\n' +

src/ReactTestHostConfig.js

@@ -82,13 +82,14 @@ export function appendChild(
   child: Instance | TextInstance,
 ): void {
   if (__DEV__) {
-    warning(
-      Array.isArray(parentInstance.children),
-      'An invalid container has been provided. ' +
-        'This may indicate that another renderer is being used in addition to the test renderer. ' +
-        '(For example, ReactDOM.createPortal inside of a ReactTestRenderer tree.) ' +
-        'This is not supported.',
-    );
+    if (!Array.isArray(parentInstance.children)) {
+      warning(
+        'An invalid container has been provided. ' +
+          'This may indicate that another renderer is being used in addition to the test renderer. ' +
+          '(For example, ReactDOM.createPortal inside of a ReactTestRenderer tree.) ' +
+          'This is not supported.',
+      );
+    }
   }
   const index = parentInstance.children.indexOf(child);
   if (index !== -1) {
@@ -216,12 +217,13 @@ export function createTextInstance(
 ): TextInstance {
   if (__DEV__) {
     if (enableFlareAPI) {
-      warning(
-        hostContext !== EVENT_COMPONENT_CONTEXT,
-        'validateDOMNesting: React event components cannot have text DOM nodes as children. ' +
-          'Wrap the child text "%s" in an element.',
-        text,
-      );
+      if (hostContext === EVENT_COMPONENT_CONTEXT) {
+        warning(
+          'validateDOMNesting: React event components cannot have text DOM nodes as children. ' +
+            'Wrap the child text "%s" in an element.',
+          text,
+        );
+      }
     }
   }
   return {

src/ReactTestRendererAct.js

@@ -84,7 +84,6 @@ function act(callback: () => Thenable) {
       if (actingUpdatesScopeDepth > previousActingUpdatesScopeDepth) {
         // if it's _less than_ previousActingUpdatesScopeDepth, then we can assume the 'other' one has warned
         warningWithoutStack(
-          null,
           'You seem to have overlapping act() calls, this is not supported. ' +
             'Be sure to await previous act() calls before making a new one. ',
         );
@@ -117,7 +116,6 @@ function act(callback: () => Thenable) {
           .then(() => {
             if (called === false) {
               warningWithoutStack(
-                null,
                 'You called act(async () => ...) without await. ' +
                   'This could lead to unexpected testing behaviour, interleaving multiple act ' +
                   'calls and mixing their scopes. You should - await act(async () => ...);',
@@ -164,12 +162,13 @@ function act(callback: () => Thenable) {
     };
   } else {
     if (__DEV__) {
-      warningWithoutStack(
-        result === undefined,
-        'The callback passed to act(...) function ' +
-          'must return undefined, or a Promise. You returned %s',
-        result,
-      );
+      if (result !== undefined) {
+        warningWithoutStack(
+          'The callback passed to act(...) function ' +
+            'must return undefined, or a Promise. You returned %s',
+          result,
+        );
+      }
     }
 
     // flush effects until none remain, and cleanup
@@ -193,7 +192,6 @@ function act(callback: () => Thenable) {
       then(resolve: () => void) {
         if (__DEV__) {
           warningWithoutStack(
-            false,
             'Do not await the result of calling act(...) with sync logic, it is not a Promise.',
           );
         }