Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug masks arrays and object contents #1476

Closed
blainekasten opened this issue Jan 12, 2018 · 2 comments
Closed

Debug masks arrays and object contents #1476

blainekasten opened this issue Jan 12, 2018 · 2 comments
Labels
API: mount API: shallow feature request Issues asking for stuff that would be semver-minor question

Comments

@blainekasten
Copy link
Contributor

Repl for example

This was just raised as an issue in enzyme-matchers.

I expected debug to print everything. Should it? If not, any advice on a different way to implement a strict matching element?

@ljharb
Copy link
Member

ljharb commented Jan 12, 2018

In 4f4c233, i improved the output for boxed primitives, but did not change the behavior for non-function objects.

I think that would be reasonable, and it'd be pretty trivial to change the debug output. @lelandrichardson, any idea why it was this way in the first place?

One possibility is that it could be done via an option to debug, so that the default output is minimal but the more verbose output is achievable.

@ljharb
Copy link
Member

ljharb commented Mar 14, 2018

Fixed in #1547.

@ljharb ljharb closed this as completed Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API: mount API: shallow feature request Issues asking for stuff that would be semver-minor question
Projects
None yet
Development

No branches or pull requests

2 participants