Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on github.com/census-instrumentation/opencensus-proto #1014

Open
codyoss opened this issue Oct 4, 2024 · 3 comments
Open

Comments

@codyoss
Copy link

codyoss commented Oct 4, 2024

Open Census is now deprecated and the project mentioned archive has been archived for over a year. I have seen some dependency issues popping up in the go/proto/grpc space and have traced it back to this dependency having a really old refs on google.golang.org/genproto in this repo. Is there a plan to remove this dependency from the tree? As another issue pointed out, which I have linked below, this can also pose a security risk to depend upon projects that are not getting updated.

Previous issue that was autoclosed: #952

@kyessenov
Copy link
Contributor

We cannot remove it until OpenCensus is deleted in Envoy core extensions. How does this cause issue for genproto? It's just another proto?

@codyoss
Copy link
Author

codyoss commented Oct 7, 2024

@kyessenov it is related to the issue linked above. TLDR is we did a module split to limit the dependencies pulled into some projects that depend on genproto. But this can cause an ambiguous import if you have a really old ref to genproto these days -- such as demonstrated in this open census project.

We cannot remove it until OpenCensus is deleted in Envoy core extensions.

Is this planned work, and is there an issue we can follow?

@kyessenov
Copy link
Contributor

envoyproxy/envoy#9958 is the issue tracking the replacement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants