chore(make): exit on failure #7387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7387 +/- ##
==========================================
+ Coverage 72.31% 72.32% +0.01%
==========================================
Files 231 231
Lines 33999 33999
==========================================
+ Hits 24587 24591 +4
+ Misses 7644 7642 -2
+ Partials 1768 1766 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zirain
approved these changes
Oct 31, 2025
Signed-off-by: Maxime Brunet <max@brnt.mx>
maxbrunet
force-pushed
the
chore/make/exit-on-failure
branch
from
f2253f6 to
5d4041e
Compare
kkk777-7
approved these changes
Nov 1, 2025
ekline-ai
pushed a commit
to ekline-ai/envoyproxy-gateway
that referenced
this pull request
Nov 2, 2025
Signed-off-by: Maxime Brunet <max@brnt.mx> Co-authored-by: zirain <zirain2009@gmail.com> Signed-off-by: EkLine AI <ekline-ai@ekline.io>
ADITYATIWARI342005
pushed a commit
to ADITYATIWARI342005/envoyproxy_gateway
that referenced
this pull request
Nov 3, 2025
Signed-off-by: Maxime Brunet <max@brnt.mx> Co-authored-by: zirain <zirain2009@gmail.com> Signed-off-by: ADITYA TIWARI <142050150+ADITYATIWARI342005@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Chore
What this PR does / why we need it:
Catch errors
Which issue(s) this PR fixes:
Can be merged after #7385,
#7386#7389, and #7398Release Notes: No