add linting

[skriss]

Linting should be added to the project. Ideally it can be run both locally by developers, via a make task, and in GitHub Actions.

Suggested tools:

• golangci-lint for Go
• yamlllint for YAML
• codespell (TODO golangci-lint has misspell; is that sufficient?)

[vince-0202]

Are we going to use Go 1.18?
There seem to be some unresolved issues regarding golangci-lint support for Go1.18.
golangci/golangci-lint#2649

[danehans]

@vince-0202 thanks for making us aware of the golangci-lint issue. We currently plan on using 1.18.2, so the golangci-lint portion of this issue is blocked until golangci/golangci-lint#2649 is fixed or if we decide to use 1.17.x instead.

xref: https://github.com/envoyproxy/gateway/pull/72/files#diff-868425f4c6dd9927d83974d334ea46b9ec96854cdac9bb15b15f43bc4ad17820R6

[lianghao208]

so the golangci-lint portion of this issue is blocked until golangci/golangci-lint#2649 is fixed or if we decide to use 1.17.x instead.

/assign

I think we should wait until golangci/golangci-lint#2649 has been fixed.

[danehans]

@lianghao208 feel free to assign yourself the issue if you would like to work on it. I suggest using Contour as reference model as I believe it has implemented these linters.

[lianghao208]

I suggest using Contour as reference model as I believe it has implemented these linters.

@danehans Thanks for the suggestion, I've added linters referring to the Contour.

[danehans]

Closing as all linters have been added.