Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use built image for conformance tests #683

Open
skriss opened this issue Nov 2, 2022 · 1 comment
Open

CI: use built image for conformance tests #683

skriss opened this issue Nov 2, 2022 · 1 comment
Labels
area/ci CI and build related issues help wanted Extra attention is needed
Milestone

Comments

@skriss
Copy link
Contributor

skriss commented Nov 2, 2022

Description:

Right now, our CI builds a Docker image twice -- once as part of the make conformance task, and once as part of the Docker build/push steps. We should de-dupe this so we build the image once, use it to run conformance, and then push that same image to Docker Hub if it's a push build.

@skriss skriss added help wanted Extra attention is needed area/ci CI and build related issues labels Nov 2, 2022
@arkodg arkodg self-assigned this Nov 2, 2022
@skriss
Copy link
Contributor Author

skriss commented Nov 2, 2022

Actually looks like we don't build the image a second time unless it's a push build to main, but we do still build the binaries for multiple arches twice per the above description.

@danehans danehans added this to the Backlog milestone Dec 1, 2022
@arkodg arkodg removed their assignment Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI and build related issues help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants