Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash the Names of Managed Infra Resources #441

Closed
danehans opened this issue Sep 28, 2022 · 5 comments · Fixed by #559
Closed

Hash the Names of Managed Infra Resources #441

danehans opened this issue Sep 28, 2022 · 5 comments · Fixed by #559
Assignees
Labels
kind/bug Something isn't working provider/kubernetes Issues related to the Kubernetes provider
Milestone

Comments

@danehans
Copy link
Contributor

EG currently generates names of managed envoy infra. The names are generally constructed of gateway namespace, gateway name, etc. The names can be long and potentially exceed the allowed length (63 chars) of a Kube name. Instead, and similar to Kube, the name should be generated from a hash.

xref: #404

@danehans danehans added the provider/kubernetes Issues related to the Kubernetes provider label Sep 28, 2022
@danehans danehans added this to the 0.3.0-rc2 milestone Sep 28, 2022
@danehans danehans modified the milestones: 0.3.0-rc.2, 0.2.0 Sep 30, 2022
@danehans danehans added the kind/bug Something isn't working label Oct 3, 2022
@danehans
Copy link
Contributor Author

danehans commented Oct 3, 2022

Added bug label due to #434.

@danehans
Copy link
Contributor Author

danehans commented Oct 4, 2022

When using hashed names for managed resources, users will need to use --selector to correlate managed resources to a Gateway. For example:


$ kubectl get deploy -n envoy-gateway-system --selector=gateway.envoyproxy.io/owning-gateway-name=eg,gateway.envoyproxy.io/owning-gateway-namespace=default
NAME               READY   UP-TO-DATE   AVAILABLE   AGE
envoy-ef185hc   1/1     1            1           2m14s

It might make debugability a bit easier if we had one label that was namespace/name. @arkodg @skriss @LukeShu @youngnick thoughts?

@danehans
Copy link
Contributor Author

danehans commented Oct 4, 2022

A similar approach will be needed for the ports of the managed Envoy serivce.

@arkodg
Copy link
Contributor

arkodg commented Oct 4, 2022

I prefer if we used a hybrid approach in naming - envoy-<40-50 char namespaced name>-<short-hash> to improve debug speed.

@Alice-Lilith
Copy link
Member

I'll take this one on. Should have some bandwidth in the coming week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working provider/kubernetes Issues related to the Kubernetes provider
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants