Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session Persistence #3315

Closed
arkodg opened this issue May 1, 2024 · 6 comments · Fixed by #3841
Closed

Session Persistence #3315

arkodg opened this issue May 1, 2024 · 6 comments · Fixed by #3841
Assignees
@sanposhiho
Milestone
v1.2.0-rc1

Comments

@arkodg
Copy link
Contributor

arkodg commented May 1, 2024

Description:

Describe the desired behavior, what scenario it enables and how it
would be used.

Add support for the upstream Session Persistence feature outlined in this GEP
https://gateway-api.sigs.k8s.io/geps/gep-1619/

[optional Relevant Links:]

Any extra documentation required to understand the issue.
@arkodg arkodg added the triage label May 1, 2024
@arkodg arkodg changed the title Support Session Persistence Session Persistence May 1, 2024
@arkodg arkodg added help wanted Extra attention is needed and removed triage labels May 1, 2024
@arkodg arkodg added this to the v1.1.0-rc1 milestone May 1, 2024
@arkodg
Copy link
Contributor Author

arkodg commented May 1, 2024

blocked on #3265

@arkodg
Copy link
Contributor Author

arkodg commented May 1, 2024

related #2624 (comment)

@arkodg arkodg modified the milestones: v1.1.0-rc1, Backlog Jun 25, 2024
@sanposhiho
Copy link
Contributor

/assign

@arkodg
Copy link
Contributor Author

arkodg commented Jul 8, 2024

hey @sanposhiho thanks for picking this one up !

@arkodg arkodg removed the help wanted Extra attention is needed label Jul 8, 2024
@sanposhiho sanposhiho mentioned this issue Jul 14, 2024
Merged
@zhaohuabing
Copy link
Member

zhaohuabing commented Jul 22, 2024 •
edited
Loading

dont add support for BackendLBPolicy, it was specifically designed to support implementations without Route level support for session persistence, Envoy can support it, so imo lets reduce the number of ways to configure sessionPersistence
#2624 (comment)

@arkodg @sanposhiho Sorry for chiming in late, so the final decision is supporting session sticky in both EG BTP and Gateway BackendLBPolicy?

@zhaohuabing
Copy link
Member

zhaohuabing commented Jul 22, 2024 •
edited
Loading

dont add support for BackendLBPolicy, it was specifically designed to support implementations without Route level support for session persistence, Envoy can support it, so imo lets reduce the number of ways to configure sessionPersistence
#2624 (comment)

@arkodg @sanposhiho Sorry for chiming in late, so the final decision is supporting session sticky in both EG BTP and Gateway BackendLBPolicy?

NVM, I figured it out: strong affinity(Stateful session HTTP filter) vs weak affinity(Hash LB) :-)

@arkodg arkodg modified the milestones: Backlog, v1.2.0-rc1 Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanposhiho sanposhiho

Labels
None yet
Projects
None yet
Milestone
v1.2.0-rc1
Development

Successfully merging a pull request may close this issue.

feat: support session persistence in HTTPRouteRule sanposhiho/gateway
3 participants
@zhaohuabing @arkodg @sanposhiho