Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Gateway.Status.Addresses #330

Closed
skriss opened this issue Sep 1, 2022 · 1 comment · Fixed by #352
Closed

Set Gateway.Status.Addresses #330

skriss opened this issue Sep 1, 2022 · 1 comment · Fixed by #352
Assignees
@danehans
Labels
kind/enhancement New feature or request
Milestone
0.2.0-rc2

Comments

@skriss
Copy link
Contributor

skriss commented Sep 1, 2022

EG needs to set the Gateway.Status.Addresses field with the address that is bound for the Gateway (i.e. the Envoy LB service address). This is necessary in order to make progress with Gateway API conformance.

A related question: do all Gateways use the same address? Does this have the potential to cause any kind of conflict across Gateways/Routes?

xref #65
@skriss skriss added the kind/enhancement New feature or request label Sep 1, 2022
@skriss skriss added this to the 0.2.0-rc2 milestone Sep 1, 2022
@skriss skriss mentioned this issue Sep 6, 2022
Closed
@danehans
Copy link
Contributor

danehans commented Sep 6, 2022 •
edited
Loading

A related question: do all Gateways use the same address? Does this have the potential to cause any kind of conflict across Gateways/Routes?

For the time being, I suggest we start off simple and have all Gateways use the same Service. Therefore, all Gateways will have the same address. A conflict can occur if a user specifies a Gateway address but I suggest we state this limitation in the v0.2.0 release notes and enforce it through validation. Thoughts @arkodg @LukeShu @youngnick?

@danehans danehans self-assigned this Sep 6, 2022
This was referenced Sep 6, 2022
Closed
Closed
@skriss skriss mentioned this issue Sep 6, 2022
Closed
@danehans danehans mentioned this issue Sep 7, 2022
Merged
@arkodg arkodg mentioned this issue Sep 7, 2022
Merged
@danehans danehans mentioned this issue Sep 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danehans danehans

Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
0.2.0-rc2
Development

Successfully merging a pull request may close this issue.

Adds Support for Managing Gateway Status Addresses danehans/gateway
2 participants
@danehans @skriss