Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set k8s fields not defined in the EnvoyProxy provider config #2346

Closed
arkodg opened this issue Dec 22, 2023 · 6 comments · Fixed by #2374
Closed

Add ability to set k8s fields not defined in the EnvoyProxy provider config #2346

arkodg opened this issue Dec 22, 2023 · 6 comments · Fixed by #2374
Assignees
Labels
area/api API-related issues area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. road-to-ga stale triage

Comments

@arkodg
Copy link
Contributor

arkodg commented Dec 22, 2023

Description:
Envoy Gateway allows users to customize the Envoy Proxy fleet resources such as - Deployment, Service and HPA. These customizations are a subset of the the entire resource spec

type KubernetesDeploymentSpec struct {

Would be great if we can add a generic way to patch/set any field in the above resources so

  • users can make edits without waiting for the field to be added and exposed in a future release
  • EG doesnt need to add all fields, especially ones such as hostNetwork that are not common case scenarios

[optional Relevant Links:]

Any extra documentation required to understand the issue.

@arkodg arkodg added triage help wanted Extra attention is needed area/api API-related issues provider/kubernetes Issues related to the Kubernetes provider area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. and removed provider/kubernetes Issues related to the Kubernetes provider labels Dec 22, 2023
@Xunzhuo
Copy link
Member

Xunzhuo commented Dec 23, 2023

@zirain Thoughts on this ?

@zirain
Copy link
Contributor

zirain commented Dec 23, 2023

#2337 (comment)

@arkodg
Copy link
Contributor Author

arkodg commented Dec 26, 2023

@arkodg
Copy link
Contributor Author

arkodg commented Dec 28, 2023

thoughts on ?

merge:
  type: StrategicMerge
  spec:
    .......

@zirain
Copy link
Contributor

zirain commented Dec 28, 2023

thoughts on ?

merge:
  type: StrategicMerge
  spec:
    .......

looks good to me

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api API-related issues area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. road-to-ga stale triage
Projects
Development

Successfully merging a pull request may close this issue.

3 participants