Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Forwarded header RFC7239 #2288

Open
robd003 opened this issue Dec 11, 2023 · 2 comments
Open

Support for Forwarded header RFC7239 #2288

robd003 opened this issue Dec 11, 2023 · 2 comments
Labels
kind/enhancement New feature or request stale

Comments

@robd003
Copy link

robd003 commented Dec 11, 2023

Description:
Having support for the Forwarded header would be really useful. The issue with relying on X-Forwarded-For is that those can be forged easily. The Forwarded header supports adding a secret key so that downstream sources can validate that the header actually coming from your proxy.

If there was a way to restrict the existing X-Forwarded-* headers so they only applied to certain IP ranges that would be great. If we could have a built-in option to dynamically load IP ranges from CloudFlare upon start (with a refresh once a week) that would be a really fantastic solution.

[optional Relevant Links:]
https://datatracker.ietf.org/doc/html/rfc7239
https://developers.cloudflare.com/support/troubleshooting/restoring-visitor-ips/restoring-original-visitor-ips/
https://www.cloudflare.com/ips/

@robd003 robd003 added kind/enhancement New feature or request triage labels Dec 11, 2023
@zhaohuabing
Copy link
Member

zhaohuabing commented Dec 12, 2023

This needs to be supported in Envoy.

Related upstream issue: envoyproxy/envoy#5889

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants