From e24ada61e3f5c294f7c94f707890627b0fc76b1e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Romain=20B=C3=A9lorgey?= <628135+RomainBelorgey@users.noreply.github.com> Date: Wed, 23 Oct 2024 01:33:33 +0200 Subject: [PATCH] helm: Remove default cpu limit inside chart (#4290) Remove default cpu limit Signed-off-by: Romain BELORGEY --- charts/gateway-helm/README.md | 1 - charts/gateway-helm/values.tmpl.yaml | 1 - site/content/en/latest/install/gateway-helm-api.md | 1 - site/content/zh/latest/install/gateway-helm-api.md | 1 - test/helm/gateway-helm/certjen-custom-scheduling.out.yaml | 1 - test/helm/gateway-helm/control-plane-with-pdb.out.yaml | 1 - test/helm/gateway-helm/default-config.out.yaml | 1 - test/helm/gateway-helm/deployment-custom-topology.out.yaml | 1 - test/helm/gateway-helm/deployment-images-config.out.yaml | 1 - test/helm/gateway-helm/deployment-priorityclass.out.yaml | 1 - test/helm/gateway-helm/envoy-gateway-config.out.yaml | 1 - test/helm/gateway-helm/global-images-config.out.yaml | 1 - test/helm/gateway-helm/service-annotations.out.yaml | 1 - 13 files changed, 13 deletions(-) diff --git a/charts/gateway-helm/README.md b/charts/gateway-helm/README.md index a352ad78899..61942016a29 100644 --- a/charts/gateway-helm/README.md +++ b/charts/gateway-helm/README.md @@ -68,7 +68,6 @@ To uninstall the chart: | deployment.envoyGateway.image.tag | string | `""` | | | deployment.envoyGateway.imagePullPolicy | string | `""` | | | deployment.envoyGateway.imagePullSecrets | list | `[]` | | -| deployment.envoyGateway.resources.limits.cpu | string | `"500m"` | | | deployment.envoyGateway.resources.limits.memory | string | `"1024Mi"` | | | deployment.envoyGateway.resources.requests.cpu | string | `"100m"` | | | deployment.envoyGateway.resources.requests.memory | string | `"256Mi"` | | diff --git a/charts/gateway-helm/values.tmpl.yaml b/charts/gateway-helm/values.tmpl.yaml index a06f9f232ba..90e72f09956 100644 --- a/charts/gateway-helm/values.tmpl.yaml +++ b/charts/gateway-helm/values.tmpl.yaml @@ -31,7 +31,6 @@ deployment: imagePullSecrets: [] resources: limits: - cpu: 500m memory: 1024Mi requests: cpu: 100m diff --git a/site/content/en/latest/install/gateway-helm-api.md b/site/content/en/latest/install/gateway-helm-api.md index 937a74452ab..99023e65c6c 100644 --- a/site/content/en/latest/install/gateway-helm-api.md +++ b/site/content/en/latest/install/gateway-helm-api.md @@ -32,7 +32,6 @@ The Helm chart for Envoy Gateway | deployment.envoyGateway.image.tag | string | `""` | | | deployment.envoyGateway.imagePullPolicy | string | `""` | | | deployment.envoyGateway.imagePullSecrets | list | `[]` | | -| deployment.envoyGateway.resources.limits.cpu | string | `"500m"` | | | deployment.envoyGateway.resources.limits.memory | string | `"1024Mi"` | | | deployment.envoyGateway.resources.requests.cpu | string | `"100m"` | | | deployment.envoyGateway.resources.requests.memory | string | `"256Mi"` | | diff --git a/site/content/zh/latest/install/gateway-helm-api.md b/site/content/zh/latest/install/gateway-helm-api.md index 937a74452ab..99023e65c6c 100644 --- a/site/content/zh/latest/install/gateway-helm-api.md +++ b/site/content/zh/latest/install/gateway-helm-api.md @@ -32,7 +32,6 @@ The Helm chart for Envoy Gateway | deployment.envoyGateway.image.tag | string | `""` | | | deployment.envoyGateway.imagePullPolicy | string | `""` | | | deployment.envoyGateway.imagePullSecrets | list | `[]` | | -| deployment.envoyGateway.resources.limits.cpu | string | `"500m"` | | | deployment.envoyGateway.resources.limits.memory | string | `"1024Mi"` | | | deployment.envoyGateway.resources.requests.cpu | string | `"100m"` | | | deployment.envoyGateway.resources.requests.memory | string | `"256Mi"` | | diff --git a/test/helm/gateway-helm/certjen-custom-scheduling.out.yaml b/test/helm/gateway-helm/certjen-custom-scheduling.out.yaml index 3746f12a18d..f0c1e0d1309 100644 --- a/test/helm/gateway-helm/certjen-custom-scheduling.out.yaml +++ b/test/helm/gateway-helm/certjen-custom-scheduling.out.yaml @@ -422,7 +422,6 @@ spec: periodSeconds: 10 resources: limits: - cpu: 500m memory: 1024Mi requests: cpu: 100m diff --git a/test/helm/gateway-helm/control-plane-with-pdb.out.yaml b/test/helm/gateway-helm/control-plane-with-pdb.out.yaml index 582fab0e8b9..ab0c09e3ed3 100644 --- a/test/helm/gateway-helm/control-plane-with-pdb.out.yaml +++ b/test/helm/gateway-helm/control-plane-with-pdb.out.yaml @@ -437,7 +437,6 @@ spec: periodSeconds: 10 resources: limits: - cpu: 500m memory: 1024Mi requests: cpu: 100m diff --git a/test/helm/gateway-helm/default-config.out.yaml b/test/helm/gateway-helm/default-config.out.yaml index b4aac21b12c..655c1b7fbeb 100644 --- a/test/helm/gateway-helm/default-config.out.yaml +++ b/test/helm/gateway-helm/default-config.out.yaml @@ -422,7 +422,6 @@ spec: periodSeconds: 10 resources: limits: - cpu: 500m memory: 1024Mi requests: cpu: 100m diff --git a/test/helm/gateway-helm/deployment-custom-topology.out.yaml b/test/helm/gateway-helm/deployment-custom-topology.out.yaml index 37f58022beb..879ca6a2351 100644 --- a/test/helm/gateway-helm/deployment-custom-topology.out.yaml +++ b/test/helm/gateway-helm/deployment-custom-topology.out.yaml @@ -450,7 +450,6 @@ spec: periodSeconds: 10 resources: limits: - cpu: 500m memory: 1024Mi requests: cpu: 100m diff --git a/test/helm/gateway-helm/deployment-images-config.out.yaml b/test/helm/gateway-helm/deployment-images-config.out.yaml index 8506b87b0ee..28eba2f209e 100644 --- a/test/helm/gateway-helm/deployment-images-config.out.yaml +++ b/test/helm/gateway-helm/deployment-images-config.out.yaml @@ -422,7 +422,6 @@ spec: periodSeconds: 10 resources: limits: - cpu: 500m memory: 1024Mi requests: cpu: 100m diff --git a/test/helm/gateway-helm/deployment-priorityclass.out.yaml b/test/helm/gateway-helm/deployment-priorityclass.out.yaml index 3f82746416b..28375ac5bf0 100644 --- a/test/helm/gateway-helm/deployment-priorityclass.out.yaml +++ b/test/helm/gateway-helm/deployment-priorityclass.out.yaml @@ -422,7 +422,6 @@ spec: periodSeconds: 10 resources: limits: - cpu: 500m memory: 1024Mi requests: cpu: 100m diff --git a/test/helm/gateway-helm/envoy-gateway-config.out.yaml b/test/helm/gateway-helm/envoy-gateway-config.out.yaml index 9a3f5b4846b..e401a1062ee 100644 --- a/test/helm/gateway-helm/envoy-gateway-config.out.yaml +++ b/test/helm/gateway-helm/envoy-gateway-config.out.yaml @@ -424,7 +424,6 @@ spec: periodSeconds: 10 resources: limits: - cpu: 500m memory: 1024Mi requests: cpu: 100m diff --git a/test/helm/gateway-helm/global-images-config.out.yaml b/test/helm/gateway-helm/global-images-config.out.yaml index 38be258c7a3..14129b666b6 100644 --- a/test/helm/gateway-helm/global-images-config.out.yaml +++ b/test/helm/gateway-helm/global-images-config.out.yaml @@ -426,7 +426,6 @@ spec: periodSeconds: 10 resources: limits: - cpu: 500m memory: 1024Mi requests: cpu: 100m diff --git a/test/helm/gateway-helm/service-annotations.out.yaml b/test/helm/gateway-helm/service-annotations.out.yaml index 532988e919e..64676e18497 100644 --- a/test/helm/gateway-helm/service-annotations.out.yaml +++ b/test/helm/gateway-helm/service-annotations.out.yaml @@ -424,7 +424,6 @@ spec: periodSeconds: 10 resources: limits: - cpu: 500m memory: 1024Mi requests: cpu: 100m