Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update LLVM to 14.0.0 #21135

Merged
merged 11 commits into from
May 6, 2022
Merged

build: update LLVM to 14.0.0 #21135

merged 11 commits into from
May 6, 2022

Conversation

lizan
Copy link
Member

@lizan lizan commented May 4, 2022

Signed-off-by: Keith Smiley keithbsmiley@gmail.com
Signed-off-by: Lizan Zhou lizan@tetrate.io

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label May 4, 2022
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @wrowe

🐱

Caused by: #21135 was opened by lizan.

see: more, trace.

@lizan lizan marked this pull request as draft May 4, 2022 00:09
lizan added 5 commits May 4, 2022 07:26
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan requested a review from keith May 5, 2022 05:59
@lizan lizan marked this pull request as ready for review May 5, 2022 08:07
lizan added 2 commits May 5, 2022 01:13
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Copy link
Member

@keith keith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks for doing all the real work here!

examples/wasm-cc/docker-compose-wasm.yaml Outdated Show resolved Hide resolved
lizan added 2 commits May 6, 2022 07:12
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
keith
keith previously approved these changes May 6, 2022
@lizan lizan enabled auto-merge (squash) May 6, 2022 17:03
@lizan lizan merged commit 21a0fd6 into envoyproxy:main May 6, 2022
ravenblackx pushed a commit to ravenblackx/envoy that referenced this pull request Jun 8, 2022
Risk Level: Low
Testing: CI
Docs Changes: Added
Release Notes: Added
Platform Specific Features:

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
phlax pushed a commit to phlax/envoy that referenced this pull request Jun 10, 2022
Risk Level: Low
Testing: CI
Docs Changes: Added
Release Notes: Added
Platform Specific Features:

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
jwendell added a commit to jwendell/envoy-1 that referenced this pull request Feb 16, 2023
Recently CI saw errors like this:
```
bazel-out/k8-fastbuild/bin/external/org_llvm_releases_compiler_rt/_virtual_includes/fuzzed_data_provider/fuzzer/FuzzedDataProvider.h:194:38: error: no member named 'numeric_limits' in namespace 'std'
  return ConsumeIntegralInRange(std::numeric_limits<T>::min(),
                                ~~~~~^
```

Apparently this is due to a incompatibility between the `compiler-rt`
dependency and the clang version we use (14.0).

This is fixed by updating `compiler-rt` to match clang 14. Actually This commit
cherry-picks the relevant changes done in upstream a while ago: envoyproxy/envoy#21135
twghu pushed a commit to twghu/maistra-envoy that referenced this pull request Feb 28, 2023
Recently CI saw errors like this:
```
bazel-out/k8-fastbuild/bin/external/org_llvm_releases_compiler_rt/_virtual_includes/fuzzed_data_provider/fuzzer/FuzzedDataProvider.h:194:38: error: no member named 'numeric_limits' in namespace 'std'
  return ConsumeIntegralInRange(std::numeric_limits<T>::min(),
                                ~~~~~^
```

Apparently this is due to a incompatibility between the `compiler-rt`
dependency and the clang version we use (14.0).

This is fixed by updating `compiler-rt` to match clang 14. Actually This commit
cherry-picks the relevant changes done in upstream a while ago: envoyproxy/envoy#21135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants