HTTP/3 codec does not set end_stream properly

[jeongseokson]

Title: HTTP/3 codec does not set end_stream properly

Description:
HTTP/3 codec does not set end_stream properly for decodeHeaders, and perhaps for other methods as well.
I think the issue is that OnInitialHeadersComplete of EnvoyQuicServerStream and EnvoyQuicClientStream just passes fin argument to decodeHeaders. However, the fin argument of OnInitialHeadersComplete doesn't seem to contain the right information based on the comments in the QUICHE code.

Repro steps:
I wrote an integration test using IntegrationCodecClient::startRequest, which internally calls encodeHeaders. I set the second header_only_request to true on the client side, and found that the fin argument of EnvoyQuicServerStream::OnInitialHeadersComplete is still set to false.

I think EnvoyQuicServerStream::OnInitialHeadersComplete should pass something different from the fin argument, perhaps fin_received() derived from QuicStream.

[jeongseokson]

Can you confirm whether this is a bug or not @danzh2010?

[danzh2010]

In your test, did FIN arrive in OnBodyAvailable() with empty payload?

[jeongseokson]

I have been working on something else now but I will check it soon and probably share the test through a PR soon so that you can take a look at it.

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

[DavidSchinazi]

@RyanTheOptimist could you add "no stalebot" tag to this issue please? (or let me know how I can do it myself if there's a way)

[RyanTheOptimist]

Done!