Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IMDSv2 for AWS instance metadata calls #24592

Closed
sc0ttbeardsley opened this issue Dec 16, 2022 · 4 comments · Fixed by #24747
Closed

Add support for IMDSv2 for AWS instance metadata calls #24592

sc0ttbeardsley opened this issue Dec 16, 2022 · 4 comments · Fixed by #24747
Assignees
Labels

Comments

@sc0ttbeardsley
Copy link

sc0ttbeardsley commented Dec 16, 2022

Title: Add support for IMDSv2 for AWS instance metadata calls

Description:
Currently the AWS credentials provider uses IMDSv1 (a request/response method) but IMDSv2 (a session-oriented method) is substantially more secure, as it prevents SSRF attacks on the metadata service.

Relevant Links:
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-service.html

cc @JuniorHsu @PeterL328 @fishcakez

@sc0ttbeardsley sc0ttbeardsley added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Dec 16, 2022
@suniltheta
Copy link
Contributor

/assign

@suniltheta
Copy link
Contributor

We would like to address this post #11816 (starting Jan 23) to remove libcurl. Let us know if that timeline sounds ok.

We have the code change that does IMDSv2 using curl, but not upstream that change yet since libcurl is planned to be deprecated soon.

Please feel free to ping me on Envoy slack (suniltheta@) for further clarifications.

@sc0ttbeardsley
Copy link
Author

thanks @suniltheta that works for me

@mattklein123 mattklein123 added help wanted Needs help! area/aws and removed enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Dec 22, 2022
@suniltheta
Copy link
Contributor

Hi @mattklein123, happy new year! I am still working on removing libcurl usage. Got the http async client change to work with lambda & request signing filter extensions but I am blocked on the final part to get that change work with IAM gRPC plugin, which I am going to work on next.

Meanwhile, I though it is better to get this IMDSv2 support #24747 since this is a security feature and the change to remove libcurl might take some time to stabilize and be bug free.

I would like to get your review on the above PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants