Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support proxy level access logging for udp proxy #23241

Closed
giantcroc opened this issue Sep 26, 2022 · 1 comment
Closed

Support proxy level access logging for udp proxy #23241

giantcroc opened this issue Sep 26, 2022 · 1 comment
Labels
area/access_log area/udp enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@giantcroc
Copy link

Title: Support proxy level access logging for udp proxy

Description:

UDP proxy supports session access logging currently.
We can use log_format as followed to print stats in sessions.

[%START_TIME%] %DYNAMIC_METADATA(udp.proxy:cluster_name)%
%DYNAMIC_METADATA(udp.proxy:bytes_sent)%
%DYNAMIC_METADATA(udp.proxy:bytes_received)%
%DYNAMIC_METADATA(udp.proxy:errors_sent)%
%DYNAMIC_METADATA(udp.proxy:errors_received)%
%DYNAMIC_METADATA(udp.proxy:datagrams_sent)%
%DYNAMIC_METADATA(udp.proxy:datagrams_received)%\n

But some stats like no_route and idle_timeout can't be printed by session access logging,
because in some cases there is no session created.
So I think we should add proxy level log to enhance udp proxy access logging.
[optional Relevant Links:]

access log usage

@giantcroc giantcroc added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Sep 26, 2022
@wbpcode wbpcode added area/udp area/access_log and removed triage Issue requires triage labels Sep 27, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Oct 27, 2022
@lizan lizan closed this as completed in 33fce6b Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/access_log area/udp enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

2 participants