Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity checks on dummy configs for integration tests #20275

Open
RenjieTang opened this issue Mar 9, 2022 · 5 comments
Open

Sanity checks on dummy configs for integration tests #20275

RenjieTang opened this issue Mar 9, 2022 · 5 comments
Labels
area/quic enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue

Comments

@RenjieTang
Copy link
Contributor

This issue was discovered in #20259 which used MockClusterInfo for HTTP integration tests.

However the default value of the connect timeout would cause Quiche to complain and crash at QuicConnection::SetNetworkTimeouts.

I think default value like this doesn't make much sense.
I wonder if more of such cases exist in Envoy's integration test setups.

@RenjieTang RenjieTang added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Mar 9, 2022
@RyanTheOptimist RyanTheOptimist added area/quic and removed triage Issue requires triage labels Mar 10, 2022
@RyanTheOptimist
Copy link
Contributor

cc: @alyssawilk @danzh2010

@danzh2010
Copy link
Contributor

Thanks for bringing up this issue! I think this is indeed a config sanitization issue rather than test config being non-sense. we need to guard Envoy from bad config input.

@alyssawilk
Copy link
Contributor

+1, we shouldn't accept config which causes ENVOY_BUG later down the line.

@github-actions
Copy link

github-actions bot commented Apr 9, 2022

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 9, 2022
@danzh2010
Copy link
Contributor

needs a non-stale tag

@alyssawilk alyssawilk added the no stalebot Disables stalebot from closing an issue label Apr 11, 2022
@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quic enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue
Projects
None yet
Development

No branches or pull requests

4 participants