Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: do not hard code "h3" APLN in EnvoyQuicProofSource #18935

Open
danzh2010 opened this issue Nov 8, 2021 · 5 comments
Open

quic: do not hard code "h3" APLN in EnvoyQuicProofSource #18935

danzh2010 opened this issue Nov 8, 2021 · 5 comments
Labels
area/quic help wanted Needs help! no stalebot Disables stalebot from closing an issue

Comments

@danzh2010
Copy link
Contributor

QUICHE interfaces in quic::ProofSource doesn't pass around ALPN negotiated by BoringSsl, but Envoy filter chain retrieval uses ALPN as part of the query. Right now, we hard-code h3 as the ALPN when we construct a ConnectionSocket for server session, but we should make the negotiated APLN available from QUICHE, and use it in Envoy glue code.

@danzh2010 danzh2010 added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Nov 8, 2021
@RyanTheOptimist
Copy link
Contributor

I'm not surprised that quic::ProofSource doesn't have the ALPN, but I'm slightly surprised that it might need it. Can you say more about why we need ALPN from ProofSource as opposed to from, say, quic::QuicSession?

@danzh2010
Copy link
Contributor Author

EnvoyQuicProofSource does filter chain retrieval in order to get certs or private key to sign. And the FilterChainManager needs ALPN as part of the query. We might not have to expose ALPN directly in ProofSource, but something that can expose ALPN, i.e. QuicSession or a context object.

@rojkov rojkov added area/quic and removed triage Issue requires triage labels Nov 15, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 15, 2021
@github-actions
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@danzh2010
Copy link
Contributor Author

danzh2010 commented Dec 22, 2021

need a non-stale label

@mattklein123 mattklein123 reopened this Dec 23, 2021
@mattklein123 mattklein123 added help wanted Needs help! and removed enhancement Feature requests. Not bugs or questions. labels Dec 23, 2021
@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Dec 23, 2021
@RyanTheOptimist RyanTheOptimist added the no stalebot Disables stalebot from closing an issue label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quic help wanted Needs help! no stalebot Disables stalebot from closing an issue
Projects
None yet
Development

No branches or pull requests

4 participants