-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install envoy.exe into ProgramData/envoy/bin #17232
Comments
cc @envoyproxy/windows-dev |
I am not opposed to this. I actually do agree that having spaces on the path is a bit annoying. It is a breaking change though. @wrowe thoughts? |
here's the link from chocolatey explaining their choice https://docs.chocolatey.org/en-us/faqs#why-doesnt-a-package-install-software-to-program-files |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
I'd like to pick up this issue as a way of getting started contributing to the repo. Do people have any reservations about moving forward with this change? cc @wrowe @mattklein123 @codefromthecrypt |
Title: Install
envoy.exe
intoProgramData/envoy/bin
Description:
Right now, in the envoy-windows image, envoy.exe installs into
Program Files/envoy/envoy.exe
While this does match historic install directories, choosing this makes tooling more difficult as for example
make
struggles with spaces.It would be easier to install into
ProgramData/envoy/bin/envoy.exe
similar to the Chocolatey package manager:ProgramData/chocolately/bin/choko.exe
.Doing so wouldn't be completely unconventional, in other words, and we already write files to this directory, ex.
ProgramData/envoy/envoy.yaml
The text was updated successfully, but these errors were encountered: