Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install envoy.exe into ProgramData/envoy/bin #17232

Open
codefromthecrypt opened this issue Jul 5, 2021 · 5 comments
Open

Install envoy.exe into ProgramData/envoy/bin #17232

codefromthecrypt opened this issue Jul 5, 2021 · 5 comments
Labels

Comments

@codefromthecrypt
Copy link
Contributor

codefromthecrypt commented Jul 5, 2021

Title: Install envoy.exe into ProgramData/envoy/bin

Description:
Right now, in the envoy-windows image, envoy.exe installs into Program Files/envoy/envoy.exe

While this does match historic install directories, choosing this makes tooling more difficult as for example make struggles with spaces.

It would be easier to install into ProgramData/envoy/bin/envoy.exe similar to the Chocolatey package manager: ProgramData/chocolately/bin/choko.exe.

Doing so wouldn't be completely unconventional, in other words, and we already write files to this directory, ex. ProgramData/envoy/envoy.yaml

@codefromthecrypt codefromthecrypt added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Jul 5, 2021
@mattklein123 mattklein123 added area/windows and removed enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Jul 6, 2021
@mattklein123
Copy link
Member

cc @envoyproxy/windows-dev

@davinci26
Copy link
Member

I am not opposed to this. I actually do agree that having spaces on the path is a bit annoying. It is a breaking change though.

@wrowe thoughts?

@codefromthecrypt
Copy link
Contributor Author

here's the link from chocolatey explaining their choice https://docs.chocolatey.org/en-us/faqs#why-doesnt-a-package-install-software-to-program-files

@github-actions
Copy link

github-actions bot commented Sep 8, 2021

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Sep 8, 2021
@dio dio added help wanted Needs help! and removed stale stalebot believes this issue/PR has not been touched recently labels Sep 8, 2021
@rectified95
Copy link
Contributor

I'd like to pick up this issue as a way of getting started contributing to the repo. Do people have any reservations about moving forward with this change?

cc @wrowe @mattklein123 @codefromthecrypt
Who else can I tag to gather opinions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants