Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support Client Status Discovery Service (CSDS) #13181

Open
lidizheng opened this issue Sep 18, 2020 · 3 comments
Open

[Feature] Support Client Status Discovery Service (CSDS) #13181

lidizheng opened this issue Sep 18, 2020 · 3 comments
Labels

Comments

@lidizheng
Copy link
Contributor

lidizheng commented Sep 18, 2020

Title: [Feature] Support Client Status Discovery Service (CSDS)

Description:

Client Status Discovery Service (CSDS) is a service that exposes xDS config of a given client. It’s commonly used to query control planes for the synced xDS config of a particular sidecar proxy. However, it can also be used to query Envoy for its received xDS configuration.

As a xDS client, Envoy can dump xDS config and expose internal status of each xDS resource (#13121). The xDS config dump will share the same proto definition as admin interface. It will be an alternative way of getting config dump. As for internal status, it describes if the Envoy accepts or rejects or is pending on a specific xDS resource.

Relevant Links:

CC @htuch for more potential benefits.

@lidizheng lidizheng added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Sep 18, 2020
@mattklein123 mattklein123 added area/admin help wanted Needs help! and removed enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Sep 21, 2020
@mattklein123
Copy link
Member

It seems like we should ultimately converge on one dump/status API. Long term should we deprecate the ad-hoc config dump admin API in Envoy and move to CSDS? cc @dschaller @htuch

@htuch
Copy link
Member

htuch commented Sep 22, 2020

Always a fan of moving bits of admin to RPC, but I think you've pointed out in the past that there is a significant class of users that wants a simple curl interface? Are you thinking we might have some way to still curl the CSDS output through admin?

@mattklein123
Copy link
Member

I'm suggesting some sharing of protos at minimum, and possibly yes supporting a REST fetch of the API (which is easily supported with gRPC unary requests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants