Skip to content

Commit 591214b

Browse files
junr03jpsim
authored andcommitted
bazel: update foreign_cc and delete ranlib patch (#110)
Signed-off-by: Jose Nino jnino@lyft.com Description: bazel: update foreign_cc and delete ranlib patch Risk Level: med -- external deps might not build correctly. Testing: CI Fixes #38 Signed-off-by: JP Simard <jp@jpsim.com>
1 parent f520b47 commit 591214b

File tree

2 files changed

+8
-16
lines changed

2 files changed

+8
-16
lines changed

mobile/WORKSPACE

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
11
load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
22
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
33

4-
# TODO remove once https://github.com/bazelbuild/rules_foreign_cc/pull/253 is resolved
5-
# NOTE: this version should be kept up to date with https://github.com/lyft/envoy-edge-fork/blob/3573b07af1ab5c4cf687ced0f80e2ccc0a0b7ec2/bazel/repository_locations.bzl#L225-L230 until this is removed
4+
# NOTE: this version should be kept up to date with Envoy upstream:
5+
# https://github.com/envoyproxy/envoy/blob/master/bazel/repository_locations.bzl#L217
6+
# It currently diverges due to known issues with the android NDK and libevent.
7+
# https://github.com/lyft/envoy-mobile/issues/116
68
http_archive(
79
name = "rules_foreign_cc",
8-
patches = ["//bazel:ranlib.patch"],
9-
sha256 = "e1b67e1fda647c7713baac11752573bfd4c2d45ef09afb4d4de9eb9bd4e5ac76",
10-
strip_prefix = "rules_foreign_cc-8648b0446092ef2a34d45b02c8dc4c35c3a8df79",
11-
urls = ["https://github.com/bazelbuild/rules_foreign_cc/archive/8648b0446092ef2a34d45b02c8dc4c35c3a8df79.tar.gz"],
10+
sha256 = "c95ef9c19b713fc25fc0851f81c486e0d55ab90ead67363958327c053d2b108b",
11+
strip_prefix = "rules_foreign_cc-2b40a0098d4016f620c2ee4c10da0f46f5c90d57",
12+
# 2019-06-17
13+
urls = ["https://github.com/bazelbuild/rules_foreign_cc/archive/2b40a0098d4016f620c2ee4c10da0f46f5c90d57.tar.gz"],
1214
)
1315

1416
load("@rules_foreign_cc//:workspace_definitions.bzl", "rules_foreign_cc_dependencies")

mobile/bazel/ranlib.patch

Lines changed: 0 additions & 10 deletions
This file was deleted.

0 commit comments

Comments
 (0)