From 2ce532577a650c0fe1a731d13ddd86574197a20e Mon Sep 17 00:00:00 2001 From: Keith Smiley Date: Sun, 7 Nov 2021 10:42:10 -0800 Subject: [PATCH] bazel: disable lld on macOS (#18922) I'm not sure what changed here but it seems chromium attempts to use lld on macOS even though it doesn't ship with Xcode. This could be intentional on their part if they require folks to use an llvm toolchain instead, but this likely isn't the right move for envoy unless we vendor that toolchain ourselves. For now we can safely disable this. https://github.com/envoyproxy/envoy/issues/16482#issuecomment-962372629 Signed-off-by: Keith Smiley --- bazel/external/wee8.genrule_cmd | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/bazel/external/wee8.genrule_cmd b/bazel/external/wee8.genrule_cmd index 8c92818102fe..e54777fd3c0d 100644 --- a/bazel/external/wee8.genrule_cmd +++ b/bazel/external/wee8.genrule_cmd @@ -100,6 +100,11 @@ WEE8_BUILD_ARGS+=" v8_use_external_startup_data=false" # TODO(PiotrSikora): remove when fixed upstream. WEE8_BUILD_ARGS+=" v8_enable_shared_ro_heap=false" +# Disable lld on Darwin since it's not vendored with Xcode +if [[ $${SYSTEM} == Darwin ]]; then + WEE8_BUILD_ARGS+=" use_lld=false" +fi + # Set target architecture. if [[ $${ARCH} == "x86_64" ]]; then WEE8_BUILD_ARGS+=" target_cpu=\"x64\""