-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devcontainer docker build is broken due to old signing key #163
Comments
@phlax can you look into this one? Thanks. |
thanks for reporting this @tommyp1ckles ive shifted it to this repo as the problem afaict is with the build image that is maintained here |
@phlax Sounds good. Seems like the newer builds on your docker hub pick up the new key. Might just be a case of bumping the docker image? |
@tommyp1ckles i think you are right - i moved here because i thought the image was up to date - but actually it hasnt been bumped since october 21, and there was a new image created in envoy 13 days ago do you want to raise a PR to update the images in envoy ? the newer hash image is envoyproxy/envoy-build-ubuntu:514e2f7bc36c1f0495a523b16aab9168a4aa13b6 an example of updating previously can be seen here lmk, im happy to do it it if necessary |
@phlax Ok, sounds good. I'll make a PR. |
Created: envoyproxy/envoy#19949 Should I bump the build tools repo version as well? |
Title: devcontainer docker build is brokend due to old signing key
Description:
.devcontainer/Dockerfile
build seems to be broken due to an out of date signing key for apt.kitware.The current base image version contains the following one:
However there seems to be a newer one available:
wget -O - https://apt.kitware.com/keys/kitware-archive-latest.asc 2>/dev/null | gpg
. Bumping the devcontainer build image to514e2f7bc36c1f0495a523b16aab9168a4aa13b6
(which includes the 2022 kitware key) seems to fix the build for me.Repro steps:
run
docker build .devcontainer
or try creating dev container in VSCode.Logs:
The text was updated successfully, but these errors were encountered: