Some updates based on PR, basic simplification, overshadow correction

Author: JasoonS

codegenerator/cli/npm/envio/src/Address.res

@@ -13,14 +13,19 @@ module Evm = {
 
   // NOTE: We could use a regex for this instead, not sure if it is faster/slower than viem's 'isAddress' function
   //       `/^0x[a-fA-F0-9]{40}$/`
-  @module("viem") @private
-  external isAddress: string => bool = "isAddress"
+  // ALSO: the function is named to be overshadowed by the one below, so that we don't have to import viem in the handler code
+  @module("viem")
+  external fromStringLowercaseOrThrow: string => bool = "isAddress" 
 
+  // Reassign since the function might be used in the handler code
+  // and we don't want to have a "viem" import there. It's needed to keep "viem" a dependency
+  // of generated code instead of adding it to the indexer project dependencies.
+  // Also, we want a custom error message, which is searchable in our codebase.
   // Validate that the string is a proper address but return a lowercased value
   let fromStringLowercaseOrThrow = string => {
     // NOTE: We could use a regex for this and make this function more strict, so it only accepts lower case addresses as input
     //       eg this regex: `/^0x[a-f0-9]{40}$/`
-    if (isAddress(string)) {
+    if (fromStringLowercaseOrThrow(string)) {
       unsafeFromString(string->Js.String2.toLowerCase)
     } else {
       Js.Exn.raiseError(

codegenerator/cli/templates/static/codegen/src/eventFetching/hypersync/HyperSyncSource.res

@@ -172,24 +172,13 @@ let make = (
   let apiToken =
     Env.envioApiToken->Belt.Option.getWithDefault("3dc856dd-b0ea-494f-b27e-017b8b6b7e07")
 
-  let client =
-    if lowercaseAddresses {
-      HyperSyncClient.make(
-        ~url=endpointUrl,
-        ~apiToken,
-        ~maxNumRetries=Env.hyperSyncClientMaxRetries,
-        ~httpReqTimeoutMillis=Env.hyperSyncClientTimeoutMillis,
-        ~enableChecksumAddresses=false,
-      )
-    } else {
-      HyperSyncClient.make(
-        ~url=endpointUrl,
-        ~apiToken,
-        ~maxNumRetries=Env.hyperSyncClientMaxRetries,
-        ~httpReqTimeoutMillis=Env.hyperSyncClientTimeoutMillis,
-        ~enableChecksumAddresses=true,
-      )
-    }
+  let client = HyperSyncClient.make(
+    ~url=endpointUrl,
+    ~apiToken,
+    ~maxNumRetries=Env.hyperSyncClientMaxRetries,
+    ~httpReqTimeoutMillis=Env.hyperSyncClientTimeoutMillis,
+    ~enableChecksumAddresses=!lowercaseAddresses,
+  )
 
   let hscDecoder: ref<option<HyperSyncClient.Decoder.t>> = ref(None)
   let getHscDecoder = () => {