Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider contributing a few examples to etsdemo. #320

Closed
rahulporuri opened this issue Oct 20, 2020 · 4 comments · Fixed by #380
Closed

Consider contributing a few examples to etsdemo. #320

rahulporuri opened this issue Oct 20, 2020 · 4 comments · Fixed by #380
Assignees

Comments

@rahulporuri
Copy link
Contributor

For the 5.0.0 release, it might be good to contribute a few of the example envisage applications to the etsdemo application. The following examples work as expected and make for a good start :

  • hello world.
  • MOTD.
  • tasks attractors.
@rahulporuri rahulporuri added this to the Envisage 5.0.0 milestone Oct 20, 2020
@kitchoi
Copy link
Contributor

kitchoi commented Oct 21, 2020

Some of these examples assume a specific Python Path when they are run.
Some of them have side-effect of creating a log file in the current directory where they are run.
I am not sure etsdemo is mature enough to handle all these... it might need a bit more investigation to scope.

@rahulporuri
Copy link
Contributor Author

I think it's perfectly understadable to update/modify the existing envisage examples to suit the way etsdemo works.

@kitchoi
Copy link
Contributor

kitchoi commented Nov 30, 2020

Actually I think it is probably better to change the examples such that it can be run from anywhere: It makes etsdemo optional, and anyone can run the examples even without the demo application.

We should get rid of the side-effect of logging to a file: it is quite annoying to run an example and realize it has left behind a file.

@kitchoi
Copy link
Contributor

kitchoi commented Dec 1, 2020

After #377, #379, we are left with these actions (I think):

  • Remove logging to a file side-effect in examples. They are not particularly useful and is unexpected.
  • Move the examples into envisage, update the single URL in docs/conf.py, make sure the files are distributed as package data, and add an entry point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants