Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor formatting cleanup in kiva compiled path #783

Closed
wants to merge 2 commits into from
Closed

Minor formatting cleanup in kiva compiled path #783

wants to merge 2 commits into from

Conversation

rahulporuri
Copy link
Contributor

@rahulporuri rahulporuri commented Apr 19, 2021 •
edited
Loading

I was looking at the kiva compiled path module while reviewing #782 and I noticed awkward indentation in the module. This PR fixes that.

aaronayres35
aaronayres35 suggested changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like every changed line is now under indented by one level.
In fact the indentation looks correct on master for me, I am not sure what is going on here

kiva/agg/src/kiva_compiled_path.h Outdated Show resolved Hide resolved
kiva/agg/src/kiva_compiled_path.h Outdated Show resolved Hide resolved
CLN : Minor formatting
a6c3f1c 
	modified:   kiva/agg/src/kiva_compiled_path.h
aaronayres35
aaronayres35 reviewed Apr 20, 2021
View reviewed changes
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These now look correctly aligned on github, but when i checkout the branch and view the file on VS Code things are under indented / off. On master things look correctly aligned for me locally in VSCode...

@rahulporuri
Copy link
Contributor Author

im just going to close this. this might just be something wonky on github or maybe its spaces vs tabs or i dont know wth.

@rahulporuri rahulporuri deleted the rahulporuri-patch-2 branch April 20, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronayres35 aaronayres35 aaronayres35 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahulporuri @aaronayres35