Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Suppressing spurious type updates. #1445

Merged
merged 8 commits into from
Apr 9, 2021
Merged

Suppressing spurious type updates. #1445

merged 8 commits into from
Apr 9, 2021

Conversation

mwu-tow
Copy link
Contributor

@mwu-tow mwu-tow commented Apr 7, 2021 •
edited
Loading

Pull Request Description

Graph editor integration will suppress spurious set_type calls.
However, types will be always refreshed as part of node expression refresh.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The CHANGELOG.md was updated with the changes introduced in this PR.
  • The documentation has been updated if necessary.
  • All code conforms to the Rust style guide.
  • All code has automatic tests where possible.
  • All code has been profiled where possible.
  • All code has been manually tested in the IDE.
    - [ ] All code has been manually tested in the "debug/interface" scene.
  • All code has been manually tested by the PR owner against our test scenarios.
  • All code has been manually tested by at least one reviewer against our test scenarios.

@mwu-tow mwu-tow requested a review from farmaazon April 9, 2021 15:02
@mwu-tow mwu-tow marked this pull request as ready for review April 9, 2021 15:02
@mwu-tow mwu-tow requested a review from wdanilo as a code owner April 9, 2021 15:02
@mwu-tow mwu-tow self-assigned this Apr 9, 2021
@mwu-tow mwu-tow added Category: GUI The Graphical User Interface Difficulty: Core Contributor Should only be attempted by a core contributor Priority: Highest Should be completed ASAP Type: Enhancement An enhancement to the current state of Enso IDE labels Apr 9, 2021
farmaazon
farmaazon approved these changes Apr 9, 2021
View reviewed changes
src/rust/ide/src/ide/integration.rs Outdated Show resolved Hide resolved
@farmaazon farmaazon merged commit 42e6ea0 into develop Apr 9, 2021
@farmaazon farmaazon deleted the wip/mwu/performance-fix-1396 branch April 9, 2021 15:25
mwu-tow added a commit to enso-org/enso that referenced this pull request Oct 30, 2021
@mwu-tow
Suppressing spurious type updates. (enso-org/ide#1445)
6d8ba0b 
Original commit: enso-org/ide@42e6ea0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@farmaazon farmaazon farmaazon approved these changes

@wdanilo wdanilo Awaiting requested review from wdanilo wdanilo is a code owner

Assignees

@mwu-tow mwu-tow

Labels
Category: GUI The Graphical User Interface Difficulty: Core Contributor Should only be attempted by a core contributor Priority: Highest Should be completed ASAP Type: Enhancement An enhancement to the current state of Enso IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwu-tow @farmaazon