Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloadable VSCode extension #7861

Merged
merged 8 commits into from
Sep 23, 2023
Merged

Downloadable VSCode extension #7861

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0b0f1f8
Archive VSCode extension
JaroslavTulach Sep 21, 2023
1456304
Dedicated documentation page for VSCode extension
JaroslavTulach Sep 21, 2023
2473055
Updating changelog with a note about VSCode extension
JaroslavTulach Sep 21, 2023
cd1ef38
Prepare standard Enso+Java debugging configuration
JaroslavTulach Sep 21, 2023
e438761
Adding configuration for DAP
JaroslavTulach Sep 21, 2023
e6ae16d
Better image name
JaroslavTulach Sep 21, 2023
cdb0ba9
Merge branch 'develop' into wip/jtulach/BuildVsixExtension
JaroslavTulach Sep 22, 2023
15b82f5
Applying prettier formatting
JaroslavTulach Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/enso4igv.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Update project version
working-directory: tools/enso4igv
run: |
mvn versions:set -DnewVersion=`mvn -q -DforceStdout help:evaluate -Dexpression=project.version | cut -f1 -d -`.$GITHUB_RUN_NUMBER
mvn versions:set -DnewVersion=`mvn -q -DforceStdout help:evaluate -Dexpression=project.version | cut -f1 -d -`.`expr $GITHUB_RUN_NUMBER - 1666`
Copy link
Member Author

@JaroslavTulach JaroslavTulach Sep 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every build of enso4igv.yml github action produces extension with a unique version. The major and minor numbers are specified by human and are taken from the pom.xml. The "micro" version is the $GITHUB_RUN_NUMBER.

To avoid the "micro" version to reach the sky, feel free to bump the minor version and then decrease the $GITHUB_RUN_NUMBER by a constant (currently 1666) to start counting from zero again.


- name: Build with Maven
run: mvn -B -Pvsix package --file tools/enso4igv/pom.xml
Expand All @@ -43,5 +43,14 @@ jobs:
- name: Install Node.js modules
run: mvn -B -Pvsix npm:install --file tools/enso4igv/pom.xml

- name: Update package.json version
run: mvn -B -Pvsix npm:exec@version --file tools/enso4igv/pom.xml

- name: Build VSCode Extension
run: mvn -B -Pvsix npm:run@vsix --file tools/enso4igv/pom.xml

- name: Archive VSCode extension
uses: actions/upload-artifact@v3
with:
name: VSCode Extension
path: tools/enso4igv/*.vsix
14 changes: 13 additions & 1 deletion tools/enso4igv/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<artifactId>enso4igv</artifactId>
<packaging>nbm</packaging>
<name>Enso Language Support for NetBeans &amp; Ideal Graph Visualizer</name>
<version>1.13-NAPSHOT</version>
<version>1.15-SNAPSHOT</version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the "major and minor" version of the .nbm file and .vsix extension. Bump it up when some important functionality changes.

<build>
<plugins>
<plugin>
Expand Down Expand Up @@ -224,6 +224,18 @@
<goal>install</goal>
</goals>
</execution>
<execution>
<id>version</id>
<goals>
<goal>exec</goal>
</goals>
<configuration>
<command>version</command>
<args>
<arg>${project.version}</arg>
</args>
</configuration>
</execution>
<execution>
<id>vsix</id>
<phase>post-integration-test</phase>
Expand Down
Loading