Merge pull request #22 from ensi-platform/ensitech-273

MsNatali · web-flow · commit 149b6b168fba · 2025-02-13T10:33:33.000+03:00
ENSITECH-273 /run-tests.yml php 8.4
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -12,7 +12,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        php: [8.1, 8.2, 8.3]
+        php: [8.1, 8.2, 8.3, 8.4]
         laravel: [9.*, 10.*, 11.*]
         exclude:
           - laravel: 11.*
diff --git a/src/Specification/CompositeSpecification.php b/src/Specification/CompositeSpecification.php
@@ -34,7 +34,7 @@ public function __call(string $name, array $arguments)
         return $result === $this->rootSpecification ? $this : $result;
     }
 
-    public function nested(string $field, Specification|Closure $factory = null): static
+    public function nested(string $field, null|Specification|Closure $factory = null): static
     {
         $spec = $factory instanceof Specification
             ? $factory

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public function __call(string $name, array $arguments)`
`34`	`34`	`return $result === $this->rootSpecification ? $this : $result;`
`35`	`35`	`}`
`36`	`36`
`37`		`- public function nested(string $field, Specification\|Closure $factory = null): static`
	`37`	`+ public function nested(string $field, null\|Specification\|Closure $factory = null): static`
`38`	`38`	`{`
`39`	`39`	`$spec = $factory instanceof Specification`
`40`	`40`	`? $factory`