Fixing github actions

Author: Pong Li

.github/workflows/npm-publish.yml

@@ -5,24 +5,51 @@ name: Node.js Package
 
 on: push
 
+env:
+  CI: true
+  NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+  IASSIGN_SAUCE_USERNAME: ${{ secrets.IASSIGN_SAUCE_USERNAME }}
+  IASSIGN_SAUCE_ACCESS_KEY: ${{ secrets.IASSIGN_SAUCE_ACCESS_KEY }}
+  IASSIGN_QA_SAUCE_USERNAME: ${{ secrets.IASSIGN_QA_SAUCE_USERNAME }}
+  IASSIGN_QA_SAUCE_ACCESS_KEY: ${{ secrets.IASSIGN_QA_SAUCE_ACCESS_KEY }}
+  GIT_COMMIT: ${{ github.sha }}
+  BUILD_NUMBER: ${{ github.run_id }}
+  GIT_BRANCH: ${{ github.ref }}
+
 jobs:
   build:
     runs-on: ubuntu-latest
+
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
         with:
           node-version: 14
+
+      - name: pre-browser-test
+        run: |
+          export LAUNCHERS_COUNT=$(node -p -e "Object.keys(require('./allCustomLaunchers.json')).length")
+          export TESTS_COUNT=12
+          test $LAUNCHERS_COUNT == $TESTS_COUNT || { echo "Number of browser tests ($"TESTS_COUNT") is not the same as number of launchers ($LAUNCHERS_COUNT)"; false; }
       - run: npm ci
       - run: npm test
 
-  publish-npm:
-    needs: build
+  deploy:
     runs-on: ubuntu-latest
+    needs: build
+    if: github.ref == 'refs/heads/master'
+
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
         with:
           node-version: 14
           registry-url: https://registry.npmjs.org/
-      - run: npm ci
+      - run: |
+          npm ci
+          npm run coveralls
+          export REMOTE_VERSION=$(npm dist-tag ls immutable-assign | cut -d' ' -f 2)
+          export LOCAL_VERSION=$(node -p -e "require('./package.json').version")
+          test "$REMOTE_VERSION" != "$LOCAL_VERSION" && echo "paul debug should publish"
+          # test "$REMOTE_VERSION" != "$LOCAL_VERSION" && npm publish
+

README.md

@@ -445,6 +445,7 @@ interface IIassignOption {
 
 ## History
 
+* 2.1.5 - Migrated to github actions
 * 2.1.4 - Reduce the package size to 11.9 kB
 * 2.1.1 - Added function overload 3 to pass in known property paths (array). Refer to [example 10](#example-10-update-nested-level-object-properties-using-property-paths-overload-3)
 * 2.0.8 - Fixed bug for undefined properties.
@@ -472,8 +473,8 @@ interface IIassignOption {
 * 1.0.16 - Tested in Node.js and major browsers (IE 11, Chrome 52, Firefox 47, Edge 13, PhantomJS 2)
 
 
-[1]: https://travis-ci.org/engineforce/ImmutableAssign.svg?branch=master
-[2]: https://travis-ci.org/engineforce/ImmutableAssign
+[1]: https://github.com/engineforce/ImmutableAssign/actions/workflows/npm-publish.yml/badge.svg?branch=master
+[2]: https://github.com/engineforce/ImmutableAssign/actions
 [3]: https://badge.fury.io/js/immutable-assign.svg
 [4]: https://badge.fury.io/js/immutable-assign
 [5]: https://coveralls.io/repos/github/engineforce/ImmutableAssign/badge.svg?branch=master

karma.conf.js

@@ -1,38 +1,66 @@
 // Karma configuration
 // Generated on Wed Aug 10 2016 13:14:23 GMT+1000 (AUS Eastern Standard Time)
 var { readFileSync } = require('fs');
-var { toPairs, fromPairs } = require('lodash');
+var { toPairs, fromPairs, take } = require('lodash');
+var assert = require('assert')
 var {
   NO_PROXY,
-  TRAVIS_COMMIT,
-  TRAVIS_BUILD_NUMBER,
-  TRAVIS_BRANCH,
+  GIT_COMMIT,
+  BUILD_NUMBER,
+  GIT_BRANCH,
   CUSTOM_JOB_INDEX,
   IASSIGN_SAUCE_USERNAME,
   IASSIGN_SAUCE_ACCESS_KEY,
   IASSIGN_QA_SAUCE_USERNAME,
   IASSIGN_QA_SAUCE_ACCESS_KEY
 } = process.env;
 
+console.log("ENV", {
+  NO_PROXY,
+  GIT_COMMIT,
+  BUILD_NUMBER,
+  GIT_BRANCH,
+  CUSTOM_JOB_INDEX,
+  IASSIGN_SAUCE_USERNAME,
+  IASSIGN_SAUCE_ACCESS_KEY: `${mask(IASSIGN_SAUCE_ACCESS_KEY)}`,
+  IASSIGN_QA_SAUCE_USERNAME,
+  IASSIGN_QA_SAUCE_ACCESS_KEY: `${mask(IASSIGN_QA_SAUCE_ACCESS_KEY)}`,
+})
+
+function mask(text) {
+  if (!text) {
+    return text
+  }
+
+  if (typeof text !== "string") {
+    return text
+  }
+
+  return text.slice(0, 3) + '...' + text.slice(-3)
+}
+
 var customLaunchers = [];
 
 if (process.argv.indexOf('--browsers') <= -1) {
-  console.assert(TRAVIS_COMMIT, 'TRAVIS_COMMIT must exist');
-  console.assert(TRAVIS_BUILD_NUMBER, 'TRAVIS_BUILD_NUMBER must exist');
-  console.assert(CUSTOM_JOB_INDEX, 'CUSTOM_JOB_INDEX must exist');
+  assert(GIT_COMMIT, 'GIT_COMMIT must exist');
+  assert(BUILD_NUMBER, 'BUILD_NUMBER must exist');
+  assert(GIT_BRANCH, 'GIT_BRANCH must exist');
+  assert(CUSTOM_JOB_INDEX, 'CUSTOM_JOB_INDEX must exist');
 
   CUSTOM_JOB_INDEX = parseInt(CUSTOM_JOB_INDEX);
-  var buildId = TRAVIS_COMMIT + '-' + TRAVIS_BUILD_NUMBER;
-  var branch = TRAVIS_BRANCH || 'branch';
+  var buildId = GIT_COMMIT + '-' + BUILD_NUMBER;
 
-  if (branch !== 'master') {
+  if (branch !== 'refs/heads/master') {
     var SAUCE_USERNAME = IASSIGN_QA_SAUCE_USERNAME;
     var SAUCE_ACCESS_KEY = IASSIGN_QA_SAUCE_ACCESS_KEY;
   } else {
     var SAUCE_USERNAME = IASSIGN_SAUCE_USERNAME;
     var SAUCE_ACCESS_KEY = IASSIGN_SAUCE_ACCESS_KEY;
   }
 
+  assert(SAUCE_USERNAME, 'CUSTOM_JOB_INDEX must exist');
+  assert(SAUCE_ACCESS_KEY, 'CUSTOM_JOB_INDEX must exist');
+
   var allCustomLaunchers = JSON.parse(
     readFileSync(`./allCustomLaunchers.json`, 'utf8')
   );
@@ -41,7 +69,7 @@ if (process.argv.indexOf('--browsers') <= -1) {
   ]);
 
   console.log({
-    TRAVIS_BRANCH,
+    GIT_BRANCH,
     buildId,
     CUSTOM_JOB_INDEX,
     customLaunchers,