Skip to content

Commit 7a2b187

Browse files
authored
Dispose ValueNotifier instances in LicensePage state classes (#104589)
1 parent 74cfc3d commit 7a2b187

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

packages/flutter/lib/src/material/about.dart

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -426,6 +426,12 @@ class LicensePage extends StatefulWidget {
426426
class _LicensePageState extends State<LicensePage> {
427427
final ValueNotifier<int?> selectedId = ValueNotifier<int?>(null);
428428

429+
@override
430+
void dispose() {
431+
selectedId.dispose();
432+
super.dispose();
433+
}
434+
429435
@override
430436
Widget build(BuildContext context) {
431437
return _MasterDetailFlow(
@@ -1321,6 +1327,12 @@ class _MasterDetailScaffoldState extends State<_MasterDetailScaffold>
13211327
floatingActionButtonLocation = FloatingActionButtonLocation.endTop;
13221328
}
13231329

1330+
@override
1331+
void dispose() {
1332+
_detailArguments.dispose();
1333+
super.dispose();
1334+
}
1335+
13241336
@override
13251337
void openDetailPage(Object arguments) {
13261338
SchedulerBinding.instance.addPostFrameCallback((_) => _detailArguments.value = arguments);

0 commit comments

Comments
 (0)