Skip to content

Commit da71e6e

Browse files
authored
Update 'dump-info' usage for dart2js builds (#156187)
Dart2js updated its CLI to support generating a 'dump-info' json file by passing a "--stage" option. The "dump-info-all" stage performs a full compilation (from the provided dill) and then also generates the dump info file. Tested via the `flutter-dev` CLI locally. This results in the same output but with the addition of an extra `main.dart.js.info.json` file.
1 parent 86ce72d commit da71e6e

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/flutter_tools/lib/src/web/compiler_config.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ class JsCompilerConfig extends WebCompilerConfig {
115115
if (buildMode != BuildMode.release) '--no-minify',
116116
...toSharedCommandOptions(buildMode),
117117
'-O$optimizationLevel',
118-
if (dumpInfo) '--dump-info',
118+
if (dumpInfo) '--stage=dump-info-all',
119119
if (noFrequencyBasedMinification) '--no-frequency-based-minification',
120120
if (csp) '--csp',
121121
];

packages/flutter_tools/test/general.shard/build_system/targets/web_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -953,7 +953,7 @@ void main() {
953953
'--no-minify',
954954
'--no-source-maps',
955955
'-O4',
956-
'--dump-info',
956+
'--stage=dump-info-all',
957957
'-o',
958958
environment.buildDir.childFile('main.dart.js').absolute.path,
959959
environment.buildDir.childFile('app.dill').absolute.path,

0 commit comments

Comments
 (0)