Skip to content

Commit d6ec0cf

Browse files
authored
Change some tests to run on macs without iOS devices attached (#136463)
Some tests have been running on devicelab bots with iOS devices attached, however, they don't require an iOS device. So moving them to run on bots without iOS devices. Fixes flutter/flutter#136415.
1 parent ee7e41f commit d6ec0cf

File tree

1 file changed

+71
-29
lines changed

1 file changed

+71
-29
lines changed

.ci.yaml

Lines changed: 71 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -2945,13 +2945,17 @@ targets:
29452945
- bin/**
29462946
- .ci.yaml
29472947

2948-
- name: Mac_arm64_ios build_ios_framework_module_test
2948+
- name: Mac_arm64 build_ios_framework_module_test
29492949
recipe: devicelab/devicelab_drone
2950-
presubmit: false
2950+
bringup: true
29512951
timeout: 60
29522952
properties:
2953+
dependencies: >-
2954+
[
2955+
{"dependency": "gems", "version": "v3.3.14"}
2956+
]
29532957
tags: >
2954-
["devicelab", "ios", "mac", "arm64"]
2958+
["devicelab", "hostonly", "mac", "arm64"]
29552959
task_name: build_ios_framework_module_test
29562960
runIf:
29572961
- dev/**
@@ -3324,7 +3328,7 @@ targets:
33243328
- bin/**
33253329
- .ci.yaml
33263330

3327-
- name: Mac_arm64_ios module_test_ios
3331+
- name: Mac_arm64_ios module_test_ios # Must be run on devicelab bot for codesigning https://github.com/flutter/flutter/issues/112033
33283332
recipe: devicelab/devicelab_drone
33293333
presubmit: false
33303334
timeout: 60
@@ -3391,13 +3395,17 @@ targets:
33913395
- bin/**
33923396
- .ci.yaml
33933397

3394-
- name: Mac_arm64_ios plugin_lint_mac
3398+
- name: Mac_arm64 plugin_lint_mac
33953399
recipe: devicelab/devicelab_drone
3396-
presubmit: false
3400+
bringup: true
33973401
timeout: 60
33983402
properties:
3403+
dependencies: >-
3404+
[
3405+
{"dependency": "gems", "version": "v3.3.14"}
3406+
]
33993407
tags: >
3400-
["devicelab", "ios", "mac", "arm64"]
3408+
["devicelab", "hostonly", "mac", "arm64"]
34013409
task_name: plugin_lint_mac
34023410
runIf:
34033411
- dev/**
@@ -3967,24 +3975,33 @@ targets:
39673975
["devicelab", "ios", "mac", "arm64"]
39683976
task_name: hello_world_ios__compile
39693977

3970-
- name: Mac_ios hot_mode_dev_cycle_macos_target__benchmark
3978+
- name: Mac_x64 hot_mode_dev_cycle_macos_target__benchmark
39713979
recipe: devicelab/devicelab_drone
3980+
bringup: true
39723981
timeout: 60
39733982
properties:
3983+
dependencies: >-
3984+
[
3985+
{"dependency": "gems", "version": "v3.3.14"}
3986+
]
39743987
tags: >
3975-
["devicelab", "ios", "mac"]
3988+
["devicelab", "hostonly", "mac"]
39763989
task_name: hot_mode_dev_cycle_macos_target__benchmark
39773990
runIf:
39783991
- dev/**
39793992
- .ci.yaml
39803993

3981-
- name: Mac_arm64_ios hot_mode_dev_cycle_macos_target__benchmark
3994+
- name: Mac_arm64 hot_mode_dev_cycle_macos_target__benchmark
39823995
recipe: devicelab/devicelab_drone
3983-
presubmit: false
3996+
bringup: true
39843997
timeout: 60
39853998
properties:
3999+
dependencies: >-
4000+
[
4001+
{"dependency": "gems", "version": "v3.3.14"}
4002+
]
39864003
tags: >
3987-
["devicelab", "ios", "mac", "arm64"]
4004+
["devicelab", "hostonly", "mac", "arm64"]
39884005
task_name: hot_mode_dev_cycle_macos_target__benchmark
39894006
runIf:
39904007
- dev/**
@@ -4119,22 +4136,30 @@ targets:
41194136
["devicelab", "ios", "mac"]
41204137
task_name: large_image_changer_perf_ios
41214138

4122-
- name: Mac_ios macos_chrome_dev_mode
4139+
- name: Mac_x64 macos_chrome_dev_mode
41234140
recipe: devicelab/devicelab_drone
4124-
presubmit: false
4141+
bringup: true
41254142
timeout: 60
41264143
properties:
4144+
dependencies: >-
4145+
[
4146+
{"dependency": "gems", "version": "v3.3.14"}
4147+
]
41274148
tags: >
4128-
["devicelab", "ios", "mac"]
4149+
["devicelab", "hostonly", "mac"]
41294150
task_name: macos_chrome_dev_mode
41304151

4131-
- name: Mac_arm64_ios macos_chrome_dev_mode
4152+
- name: Mac_arm64 macos_chrome_dev_mode
41324153
recipe: devicelab/devicelab_drone
4133-
presubmit: false
4154+
bringup: true
41344155
timeout: 60
41354156
properties:
4157+
dependencies: >-
4158+
[
4159+
{"dependency": "gems", "version": "v3.3.14"}
4160+
]
41364161
tags: >
4137-
["devicelab", "ios", "mac", "arm64"]
4162+
["devicelab", "hostonly", "mac", "arm64"]
41384163
task_name: macos_chrome_dev_mode
41394164

41404165
- name: Mac_ios microbenchmarks_ios
@@ -4161,13 +4186,17 @@ targets:
41614186
}
41624187
bringup: true
41634188

4164-
- name: Mac_ios native_assets_ios_simulator
4189+
- name: Mac native_assets_ios_simulator
41654190
recipe: devicelab/devicelab_drone
4166-
presubmit: false
4191+
bringup: true
41674192
timeout: 60
41684193
properties:
4194+
dependencies: >-
4195+
[
4196+
{"dependency": "gems", "version": "v3.3.14"}
4197+
]
41694198
tags: >
4170-
["devicelab", "ios", "mac"]
4199+
["devicelab", "hostonly", "mac"]
41714200
task_name: native_assets_ios_simulator
41724201

41734202
- name: Mac_ios native_assets_ios
@@ -4305,13 +4334,17 @@ targets:
43054334
["devicelab", "ios", "mac"]
43064335
task_name: hot_mode_dev_cycle_ios__benchmark
43074336

4308-
- name: Mac_ios hot_mode_dev_cycle_ios_simulator
4337+
- name: Mac_x64 hot_mode_dev_cycle_ios_simulator
43094338
recipe: devicelab/devicelab_drone
4310-
presubmit: false
4339+
bringup: true
43114340
timeout: 60
43124341
properties:
4342+
dependencies: >-
4343+
[
4344+
{"dependency": "gems", "version": "v3.3.14"}
4345+
]
43134346
tags: >
4314-
["devicelab", "ios", "mac"]
4347+
["devicelab", "hostonly", "mac"]
43154348
task_name: hot_mode_dev_cycle_ios_simulator
43164349

43174350
- name: Mac_ios fullscreen_textfield_perf_ios__e2e_summary
@@ -4430,12 +4463,17 @@ targets:
44304463
- bin/**
44314464
- .ci.yaml
44324465

4433-
- name: Mac_arm64_ios run_debug_test_macos
4466+
- name: Mac_arm64 run_debug_test_macos
44344467
recipe: devicelab/devicelab_drone
4468+
bringup: true
44354469
timeout: 60
44364470
properties:
4471+
dependencies: >-
4472+
[
4473+
{"dependency": "gems", "version": "v3.3.14"}
4474+
]
44374475
tags: >
4438-
["devicelab", "ios", "mac", "arm64"]
4476+
["devicelab", "hostonly", "mac", "arm64"]
44394477
task_name: run_debug_test_macos
44404478
runIf:
44414479
- dev/**
@@ -4461,13 +4499,17 @@ targets:
44614499
- bin/**
44624500
- .ci.yaml
44634501

4464-
- name: Mac_arm64_ios run_release_test_macos
4502+
- name: Mac_arm64 run_release_test_macos
44654503
recipe: devicelab/devicelab_drone
4466-
presubmit: false
4504+
bringup: true
44674505
timeout: 60
44684506
properties:
4507+
dependencies: >-
4508+
[
4509+
{"dependency": "gems", "version": "v3.3.14"}
4510+
]
44694511
tags: >
4470-
["devicelab", "ios", "mac", "arm64"]
4512+
["devicelab", "hostonly", "mac", "arm64"]
44714513
task_name: run_release_test_macos
44724514
runIf:
44734515
- dev/**

0 commit comments

Comments
 (0)