Commit d4cffa2
authored
[a11y] Update semantics in bottom_navigation_bar.dart (#150576)
issue: flutter/flutter#117997
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md1 parent 9988510 commit d4cffa2
File tree
2 files changed
+16
-1
lines changed- packages/flutter
- lib/src/material
- test/material
2 files changed
+16
-1
lines changedLines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
605 | 605 | | |
606 | 606 | | |
607 | 607 | | |
| 608 | + | |
608 | 609 | | |
609 | 610 | | |
610 | 611 | | |
| |||
Lines changed: 15 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2108 | 2108 | | |
2109 | 2109 | | |
2110 | 2110 | | |
| 2111 | + | |
2111 | 2112 | | |
2112 | 2113 | | |
2113 | 2114 | | |
| |||
2119 | 2120 | | |
2120 | 2121 | | |
2121 | 2122 | | |
| 2123 | + | |
2122 | 2124 | | |
2123 | 2125 | | |
2124 | 2126 | | |
| |||
2129 | 2131 | | |
2130 | 2132 | | |
2131 | 2133 | | |
| 2134 | + | |
2132 | 2135 | | |
2133 | 2136 | | |
2134 | 2137 | | |
| |||
2165 | 2168 | | |
2166 | 2169 | | |
2167 | 2170 | | |
| 2171 | + | |
2168 | 2172 | | |
2169 | 2173 | | |
2170 | 2174 | | |
| |||
2176 | 2180 | | |
2177 | 2181 | | |
2178 | 2182 | | |
| 2183 | + | |
2179 | 2184 | | |
2180 | 2185 | | |
2181 | 2186 | | |
| |||
2186 | 2191 | | |
2187 | 2192 | | |
2188 | 2193 | | |
| 2194 | + | |
2189 | 2195 | | |
2190 | 2196 | | |
2191 | 2197 | | |
| |||
2518 | 2524 | | |
2519 | 2525 | | |
2520 | 2526 | | |
| 2527 | + | |
2521 | 2528 | | |
2522 | 2529 | | |
2523 | 2530 | | |
| |||
2529 | 2536 | | |
2530 | 2537 | | |
2531 | 2538 | | |
| 2539 | + | |
2532 | 2540 | | |
2533 | 2541 | | |
2534 | 2542 | | |
| |||
2563 | 2571 | | |
2564 | 2572 | | |
2565 | 2573 | | |
| 2574 | + | |
2566 | 2575 | | |
2567 | 2576 | | |
2568 | 2577 | | |
| |||
2574 | 2583 | | |
2575 | 2584 | | |
2576 | 2585 | | |
| 2586 | + | |
2577 | 2587 | | |
2578 | 2588 | | |
2579 | 2589 | | |
| |||
2754 | 2764 | | |
2755 | 2765 | | |
2756 | 2766 | | |
| 2767 | + | |
2757 | 2768 | | |
2758 | 2769 | | |
2759 | 2770 | | |
| |||
2762 | 2773 | | |
2763 | 2774 | | |
2764 | 2775 | | |
2765 | | - | |
| 2776 | + | |
| 2777 | + | |
| 2778 | + | |
| 2779 | + | |
2766 | 2780 | | |
2767 | 2781 | | |
2768 | 2782 | | |
| |||
0 commit comments