Skip to content

Commit cfef140

Browse files
Removed not working hyperlinks to ScriptCategory values (#165395)
<!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> ## Description Removing the hyperlinks to ScriptCategory values which are not working with only `code text`. --- ## Screenshots ### Before : <img width="1024" alt="image" src="https://github.com/user-attachments/assets/1721527b-f0d5-4d72-a6e4-bfde6d81e7fb" /> ScriptCategory.englishLike hyperlink not working: <img width="1006" alt="image" src="https://github.com/user-attachments/assets/81ff9d06-0007-4edf-958b-f2d5284ee3dd" /> ### After : <img width="1014" alt="image" src="https://github.com/user-attachments/assets/48dd2299-f71b-4978-9e10-db40827215b6" /> --- - Fixes #164877 --- ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent 479c4bb commit cfef140

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

packages/flutter/lib/src/material/material_localizations.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -236,10 +236,10 @@ abstract class MaterialLocalizations {
236236
/// the [Typography.geometryThemeFor] method in terms of the
237237
/// three language categories defined in https://material.io/go/design-typography.
238238
///
239-
/// Generally speaking, font sizes for [ScriptCategory.tall] and
240-
/// [ScriptCategory.dense] scripts - for text styles that are smaller than the
239+
/// Generally speaking, font sizes for `ScriptCategory.tall` and
240+
/// `ScriptCategory.dense` scripts - for text styles that are smaller than the
241241
/// title style - are one unit larger than they are for
242-
/// [ScriptCategory.englishLike] scripts.
242+
/// `ScriptCategory.englishLike` scripts.
243243
ScriptCategory get scriptCategory;
244244

245245
/// Formats [number] as a decimal, inserting locale-appropriate thousands

packages/flutter/lib/src/material/typography.dart

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ import 'text_theme.dart';
2424
/// the [Typography.geometryThemeFor] method in terms of the
2525
/// three language categories defined in <https://material.io/go/design-typography>.
2626
///
27-
/// Generally speaking, font sizes for [ScriptCategory.tall] and
28-
/// [ScriptCategory.dense] scripts - for text styles that are smaller than the
27+
/// Generally speaking, font sizes for `ScriptCategory.tall` and
28+
/// `ScriptCategory.dense` scripts - for text styles that are smaller than the
2929
/// title style - are one unit larger than they are for
30-
/// [ScriptCategory.englishLike] scripts.
30+
/// `ScriptCategory.englishLike` scripts.
3131
enum ScriptCategory {
3232
/// The languages of Western, Central, and Eastern Europe and much of
3333
/// Africa are typically written in the Latin alphabet. Vietnamese is a
@@ -260,12 +260,12 @@ class Typography with Diagnosticable {
260260
/// geometry.
261261
final TextTheme white;
262262

263-
/// Defines text geometry for [ScriptCategory.englishLike] scripts, such as
263+
/// Defines text geometry for `ScriptCategory.englishLike` scripts, such as
264264
/// English, French, Russian, etc.
265265
///
266266
/// This text theme is merged with either [black] or [white], depending
267267
/// on the overall [ThemeData.brightness], when the current locale's
268-
/// [MaterialLocalizations.scriptCategory] is [ScriptCategory.englishLike].
268+
/// [MaterialLocalizations.scriptCategory] is `ScriptCategory.englishLike`.
269269
///
270270
/// To look up a localized [TextTheme], use the overall [Theme], for
271271
/// example: `Theme.of(context).textTheme`.
@@ -276,7 +276,7 @@ class Typography with Diagnosticable {
276276
///
277277
/// This text theme is merged with either [black] or [white], depending
278278
/// on the overall [ThemeData.brightness], when the current locale's
279-
/// [MaterialLocalizations.scriptCategory] is [ScriptCategory.dense].
279+
/// [MaterialLocalizations.scriptCategory] is `ScriptCategory.dense`.
280280
///
281281
/// To look up a localized [TextTheme], use the overall [Theme], for
282282
/// example: `Theme.of(context).textTheme`.
@@ -286,7 +286,7 @@ class Typography with Diagnosticable {
286286
///
287287
/// This text theme is merged with either [black] or [white], depending
288288
/// on the overall [ThemeData.brightness], when the current locale's
289-
/// [MaterialLocalizations.scriptCategory] is [ScriptCategory.tall].
289+
/// [MaterialLocalizations.scriptCategory] is `ScriptCategory.tall`.
290290
///
291291
/// To look up a localized [TextTheme], use the overall [Theme], for
292292
/// example: `Theme.of(context).textTheme`.
@@ -1387,7 +1387,7 @@ class Typography with Diagnosticable {
13871387
),
13881388
);
13891389

1390-
/// Defines text geometry for [ScriptCategory.englishLike] scripts, such as
1390+
/// Defines text geometry for `ScriptCategory.englishLike` scripts, such as
13911391
/// English, French, Russian, etc.
13921392
static const TextTheme englishLike2014 = TextTheme(
13931393
displayLarge: TextStyle(
@@ -1499,7 +1499,7 @@ class Typography with Diagnosticable {
14991499
),
15001500
);
15011501

1502-
/// Defines text geometry for [ScriptCategory.englishLike] scripts, such as
1502+
/// Defines text geometry for `ScriptCategory.englishLike` scripts, such as
15031503
/// English, French, Russian, etc.
15041504
///
15051505
/// The font sizes, weights, and letter spacings in this version match the
@@ -2071,7 +2071,7 @@ class Typography with Diagnosticable {
20712071
),
20722072
);
20732073

2074-
/// Defines text geometry for [ScriptCategory.englishLike] scripts, such as
2074+
/// Defines text geometry for `ScriptCategory.englishLike` scripts, such as
20752075
/// English, French, Russian, etc.
20762076
///
20772077
/// The font sizes, weights, and letter spacings in this version match the

0 commit comments

Comments
 (0)