Skip to content

Commit cb90ae4

Browse files
authored
[web] - Clean up skipped tests (#124981)
Fixes flutter/flutter#124174 Fixes flutter/flutter#124980
1 parent ad784bf commit cb90ae4

File tree

2 files changed

+6
-15
lines changed

2 files changed

+6
-15
lines changed

dev/integration_tests/web_e2e_tests/lib/common.dart

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -16,24 +16,15 @@ bool get isFirefox => window.navigator.userAgent.toLowerCase().contains('firefox
1616
/// without penetrating the shadow DOM. In the latter case, if the application
1717
/// creates platform views, this will also find platform view elements.
1818
List<Node> findElements(String selector) {
19-
final Element? glassPane = document.querySelector('flt-glass-pane');
20-
if (glassPane == null) {
19+
final Element? flutterView = document.querySelector('flutter-view');
20+
21+
if (flutterView == null) {
2122
fail(
22-
'Failed to locate <flt-glass-pane>. Possible reasons:\n'
23+
'Failed to locate <flutter-view>. Possible reasons:\n'
2324
' - The application failed to start'
2425
' - `findElements` was called before the application started'
2526
);
2627
}
2728

28-
// TODO(htoor3): Remove shadowRoot selectors once DOM structure PR is merged.
29-
final Element? flutterView = document.querySelector('flutter-view');
30-
31-
if(flutterView != null){
32-
return flutterView.querySelectorAll(selector);
33-
}
34-
35-
final ShadowRoot? shadowRoot = glassPane.shadowRoot;
36-
return shadowRoot != null
37-
? shadowRoot.querySelectorAll(selector)
38-
: glassPane.querySelectorAll(selector);
29+
return flutterView.querySelectorAll(selector);
3930
}

examples/hello_world/test_driver/smoke_web_engine_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,6 @@ void main() {
4343
<dynamic>[],
4444
) as WebElement?;
4545
expect(fltSemantics, isNotNull);
46-
}, skip: true); // https://github.com/flutter/flutter/issues/124174
46+
});
4747
});
4848
}

0 commit comments

Comments
 (0)