Skip to content

Commit c8a4c8b

Browse files
authored
Pointer events: Allow hover events from trackpad (#108116)
1 parent fc3471f commit c8a4c8b

File tree

2 files changed

+15
-5
lines changed

2 files changed

+15
-5
lines changed

packages/flutter/lib/src/gestures/events.dart

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1035,10 +1035,7 @@ class PointerHoverEvent extends PointerEvent with _PointerEventDescription, _Cop
10351035
super.tilt,
10361036
super.synthesized,
10371037
super.embedderId,
1038-
}) : // Dart doesn't support comparing enums with == in const contexts yet.
1039-
// https://github.com/dart-lang/language/issues/1811
1040-
assert(!identical(kind, PointerDeviceKind.trackpad)),
1041-
super(
1038+
}) : super(
10421039
down: false,
10431040
pressure: 0.0,
10441041
);
@@ -1156,7 +1153,9 @@ class PointerEnterEvent extends PointerEvent with _PointerEventDescription, _Cop
11561153
super.down,
11571154
super.synthesized,
11581155
super.embedderId,
1159-
}) : assert(!identical(kind, PointerDeviceKind.trackpad)),
1156+
}) : // Dart doesn't support comparing enums with == in const contexts yet.
1157+
// https://github.com/dart-lang/language/issues/1811
1158+
assert(!identical(kind, PointerDeviceKind.trackpad)),
11601159
super(
11611160
pressure: 0.0,
11621161
);

packages/flutter/test/gestures/events_test.dart

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -844,6 +844,17 @@ void main() {
844844
expect(event.synthesized, empty.synthesized);
845845
});
846846
});
847+
848+
test('Ensure certain event types are allowed', () {
849+
// Regression test for https://github.com/flutter/flutter/issues/107962
850+
expect(const PointerHoverEvent(kind: PointerDeviceKind.trackpad), isNotNull);
851+
852+
// The test passes if it compiles.
853+
});
854+
855+
test('Ensure certain event types are not allowed', () {
856+
expect(() => PointerDownEvent(kind: PointerDeviceKind.trackpad), throwsAssertionError);
857+
});
847858
}
848859

849860
void _expectTransformedEvent({

0 commit comments

Comments
 (0)