Skip to content

Commit 9bfac23

Browse files
authored
Remove duplicate testOutputsDirectory definition from integration_test package (#150224)
I noticed a getter by this name with the same implementation already exists in flutter_driver, with the same implementation as the initializer for this variable. This deletes the variable and instead exports the getter. Note that technically this could be breaking, because this version is a mutable variable instead of just a getter. But, I think this was just a mistake.
1 parent b98d485 commit 9bfac23

File tree

2 files changed

+2
-14
lines changed

2 files changed

+2
-14
lines changed

packages/integration_test/lib/integration_test_driver.dart

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,7 @@ import 'package:path/path.dart' as path;
1414

1515
import 'common.dart';
1616

17-
/// Flutter Driver test output directory.
18-
///
19-
/// Tests should write any output files to this directory. Defaults to the path
20-
/// set in the FLUTTER_TEST_OUTPUTS_DIR environment variable, or `build` if
21-
/// unset.
22-
String testOutputsDirectory =
23-
Platform.environment['FLUTTER_TEST_OUTPUTS_DIR'] ?? 'build';
17+
export 'package:flutter_driver/flutter_driver.dart' show testOutputsDirectory;
2418

2519
/// The callback type to handle [Response.data] after the test
2620
/// succeeds.

packages/integration_test/lib/integration_test_driver_extended.dart

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,7 @@ import 'package:path/path.dart' as path;
1414

1515
import 'common.dart';
1616

17-
/// Flutter Driver test output directory.
18-
///
19-
/// Tests should write any output files to this directory. Defaults to the path
20-
/// set in the FLUTTER_TEST_OUTPUTS_DIR environment variable, or `build` if
21-
/// unset.
22-
String testOutputsDirectory =
23-
Platform.environment['FLUTTER_TEST_OUTPUTS_DIR'] ?? 'build';
17+
export 'package:flutter_driver/flutter_driver.dart' show testOutputsDirectory;
2418

2519
/// The callback type to handle [Response.data] after the test
2620
/// succeeds.

0 commit comments

Comments
 (0)