Commit 99411e5
authored
Fix filled color is wrong for a focused and hovered TextField (#146976)
## Description
This PR fixes the filled color for a focused and hovered text field.
Before this PR, the filled color for a focused text field did not change when hovered, after this PR the filled color is blended with the hover color.
The change removes a `isFocused` check which deactivated the blending. This check was introduced in flutter/flutter#32776, at that time it was needed because there was also a focus color animation. Sometimes later, the focus animation was removed, see flutter/flutter#33062, but the flag was not removed.
**Before**:
https://github.com/flutter/flutter/assets/840911/9698ba82-eb67-428a-8635-8054a4b8dfaf
**After**:
https://github.com/flutter/flutter/assets/840911/4c03a137-360d-4612-8946-765d7b5c698d
## Related Issue
Fixes flutter/flutter#146573
## Tests
Adds 1 tests.1 parent 3bd2980 commit 99411e5
File tree
2 files changed
+36
-11
lines changed- packages/flutter
- lib/src/material
- test/material
2 files changed
+36
-11
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1950 | 1950 | | |
1951 | 1951 | | |
1952 | 1952 | | |
1953 | | - | |
| 1953 | + | |
1954 | 1954 | | |
1955 | 1955 | | |
1956 | 1956 | | |
| |||
Lines changed: 35 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
350 | 350 | | |
351 | 351 | | |
352 | 352 | | |
353 | | - | |
| 353 | + | |
354 | 354 | | |
355 | 355 | | |
356 | 356 | | |
| |||
409 | 409 | | |
410 | 410 | | |
411 | 411 | | |
412 | | - | |
| 412 | + | |
413 | 413 | | |
414 | 414 | | |
415 | 415 | | |
| |||
470 | 470 | | |
471 | 471 | | |
472 | 472 | | |
473 | | - | |
| 473 | + | |
474 | 474 | | |
475 | 475 | | |
476 | 476 | | |
| |||
530 | 530 | | |
531 | 531 | | |
532 | 532 | | |
533 | | - | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
534 | 559 | | |
535 | 560 | | |
536 | 561 | | |
| |||
607 | 632 | | |
608 | 633 | | |
609 | 634 | | |
610 | | - | |
| 635 | + | |
611 | 636 | | |
612 | 637 | | |
613 | 638 | | |
| |||
729 | 754 | | |
730 | 755 | | |
731 | 756 | | |
732 | | - | |
| 757 | + | |
733 | 758 | | |
734 | 759 | | |
735 | 760 | | |
| |||
784 | 809 | | |
785 | 810 | | |
786 | 811 | | |
787 | | - | |
| 812 | + | |
788 | 813 | | |
789 | 814 | | |
790 | 815 | | |
| |||
840 | 865 | | |
841 | 866 | | |
842 | 867 | | |
843 | | - | |
| 868 | + | |
844 | 869 | | |
845 | 870 | | |
846 | 871 | | |
| |||
896 | 921 | | |
897 | 922 | | |
898 | 923 | | |
899 | | - | |
| 924 | + | |
900 | 925 | | |
901 | 926 | | |
902 | 927 | | |
| |||
969 | 994 | | |
970 | 995 | | |
971 | 996 | | |
972 | | - | |
| 997 | + | |
973 | 998 | | |
974 | 999 | | |
975 | 1000 | | |
| |||
0 commit comments