Skip to content

Commit 8d7e860

Browse files
author
Jonah Williams
authored
[Impeller] fix min filter for GL external textures. (#166224)
Fixes flutter/flutter#165976 Pass through sampler options for oes external textures.
1 parent b2730aa commit 8d7e860

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

engine/src/flutter/impeller/entity/contents/texture_contents.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,10 @@ bool TextureContents::Render(const ContentContext& renderer,
208208
// coordinates.
209209
sampler_desc.width_address_mode = SamplerAddressMode::kClampToEdge;
210210
sampler_desc.height_address_mode = SamplerAddressMode::kClampToEdge;
211+
sampler_desc.min_filter = sampler_descriptor_.min_filter;
212+
sampler_desc.mag_filter = sampler_descriptor_.mag_filter;
213+
sampler_desc.mip_filter = MipFilter::kBase;
214+
211215
FSExternal::BindSAMPLEREXTERNALOESTextureSampler(
212216
pass, texture_,
213217
renderer.GetContext()->GetSamplerLibrary()->GetSampler(sampler_desc));

engine/src/flutter/impeller/entity/contents/tiled_texture_contents.cc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
#include "impeller/entity/contents/tiled_texture_contents.h"
66

77
#include "fml/logging.h"
8+
#include "impeller/core/formats.h"
89
#include "impeller/entity/contents/content_context.h"
910
#include "impeller/entity/tiled_texture_fill.frag.h"
1011
#include "impeller/entity/tiled_texture_fill_external.frag.h"
@@ -159,6 +160,10 @@ bool TiledTextureContents::Render(const ContentContext& renderer,
159160
// coordinates.
160161
sampler_desc.width_address_mode = SamplerAddressMode::kClampToEdge;
161162
sampler_desc.height_address_mode = SamplerAddressMode::kClampToEdge;
163+
sampler_desc.min_filter = sampler_descriptor_.min_filter;
164+
sampler_desc.mag_filter = sampler_descriptor_.mag_filter;
165+
sampler_desc.mip_filter = MipFilter::kBase;
166+
162167
FSExternal::BindSAMPLEREXTERNALOESTextureSampler(
163168
pass, texture_,
164169
renderer.GetContext()->GetSamplerLibrary()->GetSampler(

0 commit comments

Comments
 (0)