Skip to content

Commit 5a23a2a

Browse files
authored
Remove now-unnecessary command felt analyze. (#160986)
Closes flutter/flutter#154143. The entire engine sub-repo is now checked for Dart analysis issues, so a separate command is not needed.
1 parent 18163e3 commit 5a23a2a

File tree

4 files changed

+0
-76
lines changed

4 files changed

+0
-76
lines changed

engine/src/flutter/ci/builders/linux_web_engine_test.json

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -194,13 +194,6 @@
194194
"check-licenses"
195195
],
196196
"script": "flutter/lib/web_ui/dev/felt"
197-
},
198-
{
199-
"name": "web engine analysis",
200-
"parameters": [
201-
"analyze"
202-
],
203-
"script": "flutter/lib/web_ui/dev/felt"
204197
}
205198
]
206199
},

engine/src/flutter/lib/web_ui/dev/analyze.dart

Lines changed: 0 additions & 62 deletions
This file was deleted.

engine/src/flutter/lib/web_ui/dev/felt.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import 'dart:io' as io;
66

77
import 'package:args/command_runner.dart';
88

9-
import 'analyze.dart';
109
import 'build.dart';
1110
import 'clean.dart';
1211
import 'exceptions.dart';
@@ -18,7 +17,6 @@ import 'utils.dart';
1817

1918
CommandRunner<bool> runner =
2019
CommandRunner<bool>('felt', 'Command-line utility for building and testing Flutter web engine.')
21-
..addCommand(AnalyzeCommand())
2220
..addCommand(BuildCommand())
2321
..addCommand(CleanCommand())
2422
..addCommand(RollFallbackFontsCommand())

engine/src/flutter/lib/web_ui/dev/generate_builder_json.dart

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -117,11 +117,6 @@ class GenerateBuilderJsonCommand extends Command<bool> {
117117
'parameters': <String>['check-licenses'],
118118
'script': 'flutter/lib/web_ui/dev/felt',
119119
},
120-
<String, dynamic>{
121-
'name': 'web engine analysis',
122-
'parameters': <String>['analyze'],
123-
'script': 'flutter/lib/web_ui/dev/felt',
124-
},
125120
],
126121
};
127122
}

0 commit comments

Comments
 (0)