Skip to content

Commit 2d11b6a

Browse files
gmackallGray Mackall
andauthored
Add instructions to download the Gradle wrapper to FGP readme, and add to gitignore (#162332)
Fixes flutter/flutter#161480. Ended up going with just providing instructions instead of checking in the binary, as the instructions is just one line. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Co-authored-by: Gray Mackall <mackall@google.com>
1 parent 8b9b6a3 commit 2d11b6a

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

dev/bots/analyze.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1742,7 +1742,7 @@ class Hash256 {
17421742
// We have a policy of not checking in binaries into this repository.
17431743
// If you are adding/changing template images, use the flutter_template_images
17441744
// package and a .img.tmpl placeholder instead.
1745-
// If you have other binaries to add, please consult Hixie for advice.
1745+
// If you have other binaries to add, please consult johnmccutchan for advice.
17461746
final Set<Hash256> _legacyBinaries = <Hash256>{
17471747
// DEFAULT ICON IMAGES
17481748

@@ -2099,7 +2099,7 @@ Future<void> verifyNoBinaries(String workingDirectory, {Set<Hash256>? legacyBina
20992099
// We have a policy of not checking in binaries into this repository.
21002100
// If you are adding/changing template images, use the flutter_template_images
21012101
// package and a .img.tmpl placeholder instead.
2102-
// If you have other binaries to add, please consult Hixie for advice.
2102+
// If you have other binaries to add, please consult johnmccutchan for advice.
21032103
assert(
21042104
_legacyBinaries
21052105
.expand<int>((Hash256 hash) => <int>[hash.a, hash.b, hash.c, hash.d])
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
gradlew
2+
gradlew.bat
3+
gradle/**

packages/flutter_tools/gradle/README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,11 @@ new contributions will only be accepted in `src/main/kotlin` (and `src/test/kotl
1818

1919
### Testing
2020

21-
Tests can be run in Android Studio, or directly with Gradle: `./gradle test`
21+
To run the tests from the CLI, you first need to download the Gradle wrapper.
22+
1. Ensure you have run gclient sync recently (i.e., from the root of your framework checkout, run `gclient sync -D`).
23+
2. From this directory, run `../../../engine/src/flutter/third_party/gradle/bin/gradle wrapper`.
24+
25+
Tests can be run in Android Studio, or directly with Gradle: `./gradlew test`
2226
(note that this directory does not contain a version controlled Gradle file. You can find one in
2327
the engines `third_party` directory at
2428
`<flutter_root>/engine/src/flutter/third_party/gradle/bin/gradle`).

0 commit comments

Comments
 (0)