Skip to content

Commit 29ffb88

Browse files
authored
fix: Call codec.dispose in dev/ (#161112)
<!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> PR derived from flutter/flutter#159945. Added `codec.dispose()` for directories under `dev/`. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent 6e9b863 commit 29ffb88

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

dev/benchmarks/macrobenchmarks/lib/src/draw_atlas.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ Future<ui.Image> loadImage(String asset) async {
1010
final ui.ImmutableBuffer buffer = await ui.ImmutableBuffer.fromAsset(asset);
1111
final ui.Codec codec = await PaintingBinding.instance.instantiateImageCodecWithSize(buffer);
1212
final ui.FrameInfo frameInfo = await codec.getNextFrame();
13+
codec.dispose();
1314
return frameInfo.image;
1415
}
1516

dev/benchmarks/macrobenchmarks/lib/src/draw_vertices.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ Future<ui.Image> loadImage(String asset) async {
1010
final ui.ImmutableBuffer buffer = await ui.ImmutableBuffer.fromAsset(asset);
1111
final ui.Codec codec = await PaintingBinding.instance.instantiateImageCodecWithSize(buffer);
1212
final ui.FrameInfo frameInfo = await codec.getNextFrame();
13+
codec.dispose();
1314
return frameInfo.image;
1415
}
1516

dev/integration_tests/wide_gamut_test/lib/main.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,9 @@ Future<ui.Image> _loadImage() async {
238238
);
239239
final ui.ImageDescriptor descriptor = await ui.ImageDescriptor.encoded(buffer);
240240
final ui.Codec codec = await descriptor.instantiateCodec();
241-
return (await codec.getNextFrame()).image;
241+
final ui.FrameInfo frameInfo = await codec.getNextFrame();
242+
codec.dispose();
243+
return frameInfo.image;
242244
}
243245

244246
class MyHomePage extends StatefulWidget {

0 commit comments

Comments
 (0)