Misc docs cleanup and fixes (#155501)

Author: parlough

CONTRIBUTING.md

@@ -91,7 +91,12 @@ for how to set up your development environment, or ask in #hackers-test on Disco
 Developing for Flutter
 ----------------------
 
-If you would prefer to write code, you may wish to start with our list of good first issues for [Flutter](https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22) or for [Flutter DevTools](https://github.com/flutter/devtools/labels/good%20first%20issue). See the respective sections below for further instructions.
+If you prefer to write code, consider starting with the list of good
+first issues for [Flutter][flutter-gfi] or for [Flutter DevTools][devtools-gfi].
+Reference the respective sections below for further instructions.
+
+[flutter-gfi]: https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
+[devtools-gfi]: https://github.com/flutter/devtools/labels/good%20first%20issue
 
 ### Framework and Engine
 
@@ -162,7 +167,7 @@ API documentation
 -----------------
 
 Another great area to contribute in is sample code and API documentation. If this is an area that interests you, join our
-[Discord](./docs/contributing/Chat.md) server and introduce yourself on the #hackers-deverl, #hackers-framework,
+[Discord](./docs/contributing/Chat.md) server and introduce yourself on the #hackers-devrel, #hackers-framework,
 or #hackers-engine channels, describing your area of interest. As our API docs are integrated into our source code, see the
 "developing for Flutter" section above for a guide on how to set up your developer environment.
 

dev/conductor/README.md

@@ -23,7 +23,7 @@ unlock your ssh key for the session; if you do not, each time the conductor
 attempts to interact with a remote, the user will be prompted to enter their ssh
 key password.
 
-** Confirm that your personal github clone of flutter/flutter is named flutter and flutter/engine is named engine. If not you will need to use flags to override the defaults.
+** Confirm that your personal GitHub clone of flutter/flutter is named flutter and flutter/engine is named engine. If not you will need to use flags to override the defaults.
 
 ## Usage
 

dev/conductor/RELEASE_ONBOARDING.md

@@ -2,61 +2,70 @@
 
 Googler facing documentation can be found at go/flutter-release-workflow.
 
-### Responsiblity
+### Responsibility
 
 Release engineer is responsible for:
-* Branch alignment and/or Sheparding cherry picks
+* Branch alignment and/or shepherding cherry picks
 * Decision making related to cherry pick risk
 * Verification that pre and post submits pass prior to publishing
 * Contributor facing communication
-* Some public facing post release comunication
+* Some public facing post release communication
 
 In the past (and possibly in the future) there was a distinction between a release engineer and release manager.
-For now the responsiblitys are the same and we will refer to the person managing the release as a release engineer.
+For now the responsibilities are the same and we will refer to the person managing the release as a release engineer.
 
 ## Onboarding
-One time setup instructions for new or returning relase engineers.
+
+One time setup instructions for new or returning release engineers.
 
 ### Groups/Permissions
 
-#### Join flutter-hackers on github
+#### Join flutter-hackers on GitHub
+
 https://github.com/orgs/flutter/teams/flutter-hackers/members
 
 #### [Googler only] Join mdb/flutter-infra
+
 Possibly not required
 https://ganpati2.corp.google.com/propose_membership?parent=9147533327&child=$me.prod
 
 #### Join the flutter-announce google group
+
 Ping any current release engineer to add you as an owner and give you publish access.
 https://groups.google.com/g/flutter-announce/members?q=role:owner&pli=1
 
 TODO include screenshot
 
 #### [Googler only] Install tool-proxy-client
-From a glinux machine run
-`sudo apt install tool-proxy-client`
+
+From a glinux machine run `sudo apt install tool-proxy-client`.
 
 `tool-proxy-client` is the tool that enables/enforces 2 party authorization for controlled builds.
 
 #### [Googler only] Confirm access to release calendar
+
 Public and Beta releases and timelines
 go/dash-team-releases
 
 #### [Googler only] Join release chatroom
+
 Release hotline https://chat.google.com/room/AAAA6RKcK2k?cls=7
 
 #### [Googler only] join mdb/flutter-release-team
+
 Controls who can approve 2 party auth requests.
 https://ganpati2.corp.google.com/propose_membership?parent=100213927583&child=$me.prod
 
 #### Setup conductor
+
 Conductor is a dart command line interface for common release tasks.
 Its instructions are in README.md.
 
-
 #### [Googler only] Confirm access to Apple signing cert update doc
+
 go/flutter-signing-apple-contracts
 Also confirm access to valentine entries listed in that doc.
 
 #### [Googler only] Access release engineer doc
+
 Confirm access to go/release-eng-retros

dev/devicelab/README.md

@@ -28,7 +28,7 @@ DeviceLab tests are run against physical devices in Flutter's lab (the
 
 Tasks specify the type of device they are to run on (`linux_android`, `mac_ios`,
 `mac_android`, `windows_android`, etc). When a device in the lab is free, it
-will pickup tasks that need to be completed.
+will pick up tasks that need to be completed.
 
 1. If the task succeeds, the test runner reports the success and uploads its
 performance metrics to Flutter's infrastructure. Not all tasks record

docs/Flutter-Self-Service-Index.md

@@ -126,7 +126,7 @@ Flutter provides multiple functionality through self-service services. Most of t
    </td>
    <td>[Link](./platforms/android/Testing-Android-Changes-in-the-Devicelab-on-an-Emulator.md)
    </td>
-   <td>Flutter Github Wiki page under the “Android Development” Section.
+   <td>Flutter GitHub Wiki page under the “Android Development” Section.
    </td>
   </tr>
   <tr>
@@ -285,7 +285,7 @@ Flutter provides multiple functionality through self-service services. Most of t
    </td>
    <td><a href="https://github.com/flutter/engine/security/code-scanning">Link</a>
    </td>
-   <td><a href="https://github.com/flutter/engine/security">Engine github security tab</a>.
+   <td><a href="https://github.com/flutter/engine/security">Engine GitHub security tab</a>.
    </td>
   </tr>
   <tr>

docs/In-case-of-emergency.md

@@ -1,6 +1,7 @@
 ## If flutter.dev is down
 
-If one of our web sites is down, please ping `@emergency` on our [Discord server](./contributing/Chat.md).
+If one of our websites is down,
+please ping `@emergency` on our [Discord server](./contributing/Chat.md).
 
 ## If you find a security vulnerability
 

docs/README.md

@@ -1,6 +1,6 @@
 This wiki is primarily aimed at engineers building or making contributions to Flutter.
 
-If you are new to Flutter, then you will find more general information on the Flutter project, including tutorials and samples, on our Web site at [flutter.dev](https://flutter.dev). For specific information about Flutter's APIs, consider our API reference which can be found at the [api.flutter.dev](https://api.flutter.dev/).
+If you are new to Flutter, then you will find more general information on the Flutter project, including tutorials and samples, on our website at [flutter.dev](https://flutter.dev). For specific information about Flutter's APIs, consider our API reference which can be found at the [api.flutter.dev](https://api.flutter.dev/).
 
 If you want to know what we're likely to do in the future, our [roadmap](./roadmap/Roadmap.md) may be of interest.
 

docs/about/Glossary.md

@@ -8,9 +8,9 @@ Here are some terms that we use in the Flutter project and what they mean:
 
 - **Dynamic patching**. The ability to update the Dart code of an app in the field by downloading a patch (of sorts) and providing it to the Dart VM, probably requiring a restart of the application.
 
-- **Embedder**. The core of the Flutter engine is platform agnostic. But platforms that run Flutter applications need platform specific logic to wire up rendering to the native window toolkit, handle input events, etc.. This platform specific logic is referred to as the Flutter embedder. Embedders interact with the engine using a [very low level C/C++ API](https://github.com/flutter/engine/blob/043d92c48abdebdad926569bc204a59c5cf20a11/shell/platform/embedder/embedder.h). While this API exposed by the engine to its embedders is platform agnostic, it is usually not suitable for developers used to the tools, frameworks and libraries on that specific platform (UIKit using Objective-C/Swift on iOS, or, Android APIs using Java on Android). To make interacting with the engine more ergonomic to developers on a specific platform, there are platform specific embedding APIs ([iOS](https://docs.flutter.io/objcdoc/) and [Android](https://docs.flutter.io/javadoc/)). These APIs provide higher level abstractions but are optional.
+- **Embedder**. The core of the Flutter engine is platform agnostic. But platforms that run Flutter applications need platform specific logic to wire up rendering to the native window toolkit, handle input events, etc.. This platform specific logic is referred to as the Flutter embedder. Embedders interact with the engine using a [very low level C/C++ API](https://github.com/flutter/engine/blob/0a3423abd79c282c8a5e84a24e03733c98b31144/shell/platform/embedder/embedder.h). While this API exposed by the engine to its embedders is platform agnostic, it is usually not suitable for developers used to the tools, frameworks and libraries on that specific platform (UIKit using Objective-C/Swift on iOS, or, Android APIs using Java on Android). To make interacting with the engine more ergonomic to developers on a specific platform, there are platform specific embedding APIs ([iOS](https://api.flutter.dev/ios-embedder) and [Android](https://api.flutter.dev/javadoc/)). These APIs provide higher level abstractions but are optional.
 
-- **Embedding**. Flutter provides "embedders" to port Flutter behavior to specific platforms, as defined elsewhere in this glossary. However, embedders use a [very low level C/C++ API](https://github.com/flutter/engine/blob/043d92c48abdebdad926569bc204a59c5cf20a11/shell/platform/embedder/embedder.h) which would feel unnatural to typical developers of a platform, e.g., Android or iOS. A Flutter "embedding" is a counterpart to an "embedder", which introduces common platform tools for interacting with Flutter. The Android embedding offers a `FlutterActivity`, `FlutterFragment`, `FlutterView`, etc: [Android embedding](https://docs.flutter.io/javadoc/).  The iOS embedding offers a `FlutterViewController`, etc: [iOS embedding](https://docs.flutter.io/objcdoc/). An embedding + an embedder signifies the entire story of how Flutter ports to a specific platform.
+- **Embedding**. Flutter provides "embedders" to port Flutter behavior to specific platforms, as defined elsewhere in this glossary. However, embedders use a [very low level C/C++ API](https://github.com/flutter/engine/blob/0a3423abd79c282c8a5e84a24e03733c98b31144/shell/platform/embedder/embedder.h) which would feel unnatural to typical developers of a platform, e.g., Android or iOS. A Flutter "embedding" is a counterpart to an "embedder", which introduces common platform tools for interacting with Flutter. The Android embedding offers a `FlutterActivity`, `FlutterFragment`, `FlutterView`, etc: [Android embedding](https://api.flutter.dev/javadoc/).  The iOS embedding offers a `FlutterViewController`, etc: [iOS embedding](https://api.flutter.dev/ios-embedder). An embedding + an embedder signifies the entire story of how Flutter ports to a specific platform.
 
 - **Engine**. The C++ (and Java and ObjectiveC and...) side of Flutter. Defined in the `engine` repository. Includes Skia, Dart, and other low-level components. Exposed as `dart:ui` and other Dart libraries to author code.
 

docs/about/The-Engine-architecture.md

@@ -81,7 +81,7 @@ responsibility of the embedder to create and manage threads (and their message
 loops) for the Flutter engine. The embedder gives the Flutter engine task
 runners for the threads it manages. In addition to the threads managed by the
 embedder for the engine, the Dart VM also has its own thread pool. Neither the
-Flutter engine or the embedder have any access to the threads in this pool.
+Flutter engine nor the embedder have any access to the threads in this pool.
 
 ### Task Runner Configuration
 
@@ -122,7 +122,7 @@ Interacting with the Flutter engine in any way must happen on the platform
 thread. Interacting with the engine on any other thread will trip assertions in
 unoptimized builds and is not thread safe in release builds. There are numerous
 components in the Flutter engine that are not thread safe. Once the Flutter
-engine is setup and running, the embedder does not have to post tasks to any of
+engine is set up and running, the embedder does not have to post tasks to any of
 the task runners used to configure the engine as long as all accesses to the
 embedder API are made on the platform thread.
 

docs/contributing/Chat.md

@@ -2,7 +2,7 @@
 
 <img src="https://github.com/flutter/flutter/assets/551196/1381071b-e482-4e07-b096-60e9219d3ff7" width=300 align=right alt="">
 
-The Flutter team uses a [Discord server](https://discord.com/channels/608014603317936148). [This is invite link for Flutter's Discord server](https://discord.gg/ht477J5PyH). Please do not share either link directly, instead share links to this page.
+The Flutter team uses a [Discord server](https://discord.com/channels/608014603317936148). [This is the invite link for Flutter's Discord server](https://discord.gg/ht477J5PyH). Please do not share either link directly, instead share links to this page.
 
 The server is open to the public, though some channels are intended only for people who are actively contributing. **See the #welcome channel for instructions on posting to the server (you won't be able to see the channels until you acknowledge the rules there).**